Closed Rob-P-Smith closed 2 weeks ago
Thanks for making a pull request to jupyterlab! To try out this branch on binder, follow this link:
@meeseeksdev tag bug
Several of the test cases now fail, because the menus are different. You can comment with please update snapshots
when you're ready to regenerate both galata and documentation screenshots.
Documentation snapshots updated.
Galata snapshots updated.
Thank you for your patience Jason, trying not to make life harder on others while I learn.
I think I've satisfied your feedback.
bot please update snapshots
Documentation snapshots updated.
Galata snapshots updated.
The failure in:
[jupyterlab] › test/jupyterlab/kernel.test.ts:27:9 › Kernel › Notebook › Should remember kernel auto start for notebook
appears relevant, the test will need updating.
Audited all menu-bar options for required ellipses or removal of ellipses.
As mentioned in the commit, a few items required ellipses at certain times while not requiring them at other times. Those dual nature elements were not adjusted.
References
16025
Code changes
/packages/notebook-extension/schema/export.json line 16 removed ellipses from label /packages/notebook-extension/index.ts line 2420 added ellipses to label /packages/apputils-extension/index.ts line 653 added ellipses to label
User-facing changes
Adjusted ellipses to conform with the guidance posted in the issue. Added ellipses to Show Keyboard Shortcuts under help menu. Added ellipses to Close and Shut Down Notebook under file menu. Removed ellipses on Save and Export Notebook As under file menu.
Updated areas:
Backwards-incompatible changes
None