jupyterlab / jupyterlab

JupyterLab computational environment.
https://jupyterlab.readthedocs.io/
Other
13.81k stars 3.12k forks source link

Consider higher levels when toggling plugin #16251

Closed divyansshhh closed 2 weeks ago

divyansshhh commented 2 weeks ago

Fixes #16101

jupyterlab-probot[bot] commented 2 weeks ago

Thanks for making a pull request to jupyterlab! To try out this branch on binder, follow this link: Binder

divyansshhh commented 2 weeks ago

This was the initial commit made for jupyterlab/jupyterlab#16102 (commit link).

I think I missed redoing this change while I was adding the _is_locked checks.

@krassowski can we release another patch with this since this is a blocking change for us? Apologies for the inconvenience.

krassowski commented 2 weeks ago

It looks like having a test sequence in the usage test would help here. Do you have time to add it?

krassowski commented 2 weeks ago

can we release another patch with this since this is a blocking change for us?

I can wait a bit with releasing 4.2.0rc0 if that works for you. We try not to release too frequently unless there are critical or security bugfixes because users get annoyed by frequent notifications about updates being available. That said if we just released today maybe another bugfix release is not that bad as most users would not have upgraded yet.

divyansshhh commented 2 weeks ago

I can wait a bit with releasing 4.2.0rc0 if that works for you

4.2 has a couple of changes we want to take time and test so we would want to do thorough testing at our end before we upgrade. A 4.1 patch would be quicker to test.

We try not to release too frequently unless there are critical or security bugfixes because users get annoyed by frequent notifications about updates being available.

Yeah I understand but it'd be helpful to release another patch today.

divyansshhh commented 2 weeks ago

It looks like having a test sequence in the usage test would help here. Do you have time to add it?

Yes I'm adding this

krassowski commented 2 weeks ago

@meeseeksdev please backport to 4.1.x