jupyterlab / jupyterlab

JupyterLab computational environment.
https://jupyterlab.readthedocs.io/
Other
13.81k stars 3.12k forks source link

Labeller no longer removes outdated labels from PRs #16256

Closed krassowski closed 2 weeks ago

krassowski commented 2 weeks ago

As noted in https://github.com/jupyterlab/jupyterlab/pull/16228#issuecomment-2080050586 the labeller did not remove labels which are no longer needed. I also saw that recently @JasonWeill had to manually remove dozens of labels on https://github.com/jupyterlab/jupyterlab/pull/16207.

This was not the case previously. It appears to be the result of a recent upgrade to labeller action v5 which fixed a bug in sync-labels setting. Namely, prior to v5 the default was de-facto "true" (it was false it was incorrectly parsed to true).

I think the old behaviour was better.