fixing search and replace with cell outputs

jupyterlab / jupyterlab

JupyterLab computational environment.

https://jupyterlab.readthedocs.io/

Other

13.81k stars 3.12k forks source link

fixing search and replace with cell outputs #16260

Open BrunoNeira-cmu opened 2 weeks ago

BrunoNeira-cmu commented 2 weeks ago

References

Builds from #16157 Resolves #15966

Code changes

updated highlighting logic in genericsearchprovider.ts to support highlighting in cell outputs
updated searchmodel.ts to support disabling replace button when current match is in cell output

User-facing changes

highlights search matches even if matches are in cell outputs
disables the replace button when the current match is in the cell output.

jupyterlab-probot[bot] commented 2 weeks ago

Thanks for making a pull request to jupyterlab! To try out this branch on binder, follow this link:

welcome[bot] commented 2 weeks ago

Thanks for submitting your first pull request! You are awesome! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly. welcome You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada:

BrunoNeira-cmu commented 2 weeks ago

Currently draft PR because I'm working on disabling the Replace All button when all matches in are in cell outputs.