jupyterlab / jupyterlab

JupyterLab computational environment.
https://jupyterlab.readthedocs.io/
Other
13.94k stars 3.21k forks source link

Unexpected CSS variable for notebook cell shadows #16543

Closed joaopalmeiro closed 1 day ago

joaopalmeiro commented 3 days ago

Hi! 👋

Description

There are some CSS variables to style notebook cells from themes, such as the --jp-cell-editor-box-shadow variable: https://github.com/jupyterlab/jupyterlab/blob/841b339771d15a5ae0f0f63455eb7ed66b56d921/packages/theme-light-extension/style/variables.css#L248

However, the CSS variable used for the box-shadow property responsible for the slight blue shading around a notebook cell being used is the --jp-input-box-shadow variable, that is, the variable for generic input fields: https://github.com/jupyterlab/jupyterlab/blob/ae0ba1db9ea6ab0037270df842cea747305b8153/packages/notebook/style/base.css#L153-L157

image

For this particular case, given that there is a CSS variable that, from my perspective, exists for notebook cells, I think that the variable currently being used is unexpected, and could lead to erroneous customizations in new themes.

Expected behavior

The --jp-cell-editor-box-shadow variable is used instead of the --jp-input-box-shadow variable to customize the shadow of notebook cells.

Context

Let me know what you think and if I can open a PR. Thanks!

JasonWeill commented 3 days ago

@joaopalmeiro Thank you again! We accepted this issue at triage; please feel free to send us a PR if you have a fix for it.

joaopalmeiro commented 3 days ago

Thanks! I will work on it.