search

jupyterlab / jupyterlab

JupyterLab computational environment.
https://jupyterlab.readthedocs.io/
Other
14.13k stars 3.36k forks source link

Restyle or remove boxes around options in settings editor #16561

Open JasonWeill opened 3 months ago

JasonWeill commented 3 months ago

This is a follow-on to #14375. After this change, the boxes around certain options now have borders that look confusingly similar to the divider between the left panel of the settings widget and the main area. On macOS, the narrow scroll bar track has a slight gray coloring, but we should lighten or delete the box borders indicated by the arrow below.

image

JasonWeill commented 3 months ago

Additional settings issues noted by @andrii-i in https://github.com/jupyterlab/jupyterlab/pull/14375#issuecomment-2215383305:

krassowski commented 2 months ago

On the other hand, when objects are not grouped with this border then users frequently mistake to which section the inputs belong, see https://github.com/jupyterlab/jupyter-ai/issues/889#issuecomment-2240840271 - I saw this exact issue in a couple of different reports.

Of note if the color of the bar on the left was grey we would not have this issue ;)