Text editor theme not applying to notebooks

[rctonnies]

Hi, I've not posted on here before; read through the guidelines and tried to find this issue in a previous thread.

The Text Editor theme changes the style for everything except .ipynb lab files, which remain in the default Dark or Light styled theme. Any other type of text file obeys the text editor theme selection on the fly and instantly.

Not sure if this is intentional or a problem just on my environment. Have tried fixing this for hours, with most forums referring to theme changes for Notebook, I've not found anything. Would LOVE to be able to have the notebooks display the selected Editor theme. :)

[jasongrout]

The thinking here is that the "Text Editor theme" is referring to the text file editor tabs, not the generic code editor used also in the notebook. IIRC, right now there isn't a way to switch the theme for notebook code cell editors. Definitely +1 to making possible though - thanks for filing the issue!

[ian-r-rose]

Hi @rctonnies, for similar reasons to #3992/#1362, text editor themes are not applied to the notebook. It is a more specialized document than a plain text file, and it is difficult to combine arbitrary text editor themes with the rest of the document theme.

It is definitely possible to write an extension to do this if you want to explore it, however. I'd be happy to help guide in that process if anybody wants to take a crack at it.

[bollwyvl]

On Mon, Sep 17, 2018, 11:18 Ian Rose notifications@github.com wrote:

Hi @rctonnies https://github.com/rctonnies, for similar reasons to #3992 https://github.com/jupyterlab/jupyterlab/issues/3992/#1362 https://github.com/jupyterlab/jupyterlab/issues/1362, text editor keymaps are not applied to the notebook.

Eek ... Don't want to think about keymaps!

Itt is a more specialized document than a plain text file, and it is difficult to combine arbitrary text editor themes with the rest of the document theme.

It is definitely possible to write an extension to do this if you want to explore it, however. I'd be happy to help guide in that process if anybody wants to take a crack at it.

Yum. Do want.

The base 'jupyter' theme, which is unapologetically python-focused, makes some tokens very hard to distinguish for certain modes. Indeed, per kernel/file type modes would be really nice.

While I don't like nested menus, since it's always picking from the list of themes, perhaps having:

editor theme ->
[jupyter | ... | Zenburn] ->
[Editor | ... | Notebook] ->
[default | Ada | ... | Zsh]

Though it could be contextual, based on the active document, skipping a layer.

Another thing I've been wondering about is a mime type of codemirror simple modes...

[ian-r-rose]

Oops, meant to say "themes" in the first sentence above!

[Nathan-Furnal]

Any update on this issue?

I'd like to be able to use a dark theme because it's easier on my eyes with Zenburn for the text editor. Though there's the [V] next to Zenburn, jupyterlab doesn't change the layout.

On jupyter lab 0.35.6 and notebook 5.7.8.

[xgdgsc]

Could we combine https://github.com/dunovank/jupyter-themes to provide notebook themes? I also thought editor theme was for notebooks.

[udaychadha]

Checking in to see if there's any update on this. Just started using labs from notebooks and wanted to setup my notebook theme.

[damienstanton]

Even if this feature does not end up being implemented, it may simply be worth changing the verbiage of "Text Editor Theme". Many people (myself included) thought that this would mean the cells where text is edited, not the UI tabs.

Would it make sense to change this from "Text Editor Theme" to "UI Theme" or "Tab Theme"?

[kwcooper]

@xgdgsc I agree. I have had good milage with the updates with jupyter-lab support: ie. https://github.com/dunovank/jupyterlab_darkside_ui