search

jupyterlab / jupyterlab

JupyterLab computational environment.
https://jupyterlab.readthedocs.io/
Other
14.18k stars 3.39k forks source link

Integrate "Control Panel" and "Logout" buttons when launched from JupyterHub #745

Closed sofianeh closed 7 years ago

sofianeh commented 8 years ago

These two buttons are missing, I don't see a way to logout directly from Lab It would be nice to integrate "Control Panel" and "Logout" functionalities when Lab is launched from JupyterHub

Here's how they appear on the tree view (c.f. notebook):

2016-08-24 16_55_06-home

ellisonbg commented 8 years ago

Yep, in JupyterLab these will be handled by plugin. Pinging @minrk

Two parts of this:

jasongrout commented 8 years ago

I think this issue should be moved to jupyterhub, which would be the place for such a plugin to live.

minrk commented 8 years ago

@jasongrout - there's a task on either side. The first bullet (make sure it's possible) is on the Lab side, the second (do it) is on the JupyterHub side. In particular, I need a place in the jinja template to add items, which I don't see in the lab.html currently. If the static HTML injection isn't the way to go, that's fine, but I still need a way to specify to JupyterLab that things should be added to the Lab page at the Python application level.

@ellisonbg I also need some design input for how to add these things in Lab, which lacks the header of the 4.x notebook. Should it be a menu item? A command?

jasongrout commented 8 years ago

If the static HTML injection isn't the way to go, that's fine, but I still need a way to specify to JupyterLab that things should be added to the Lab page at the Python application level.

Static html wouldn't be the way to go. The way to do this is to implement a plugin (javascript) and register that plugin with jupyterlab (which is a python thing). We're discussing how to do this in #224 #728. Likely the plugin should register these in a top-level menu item, or perhaps as buttons over on the right of the menubar. And commands for each as well.

I think we should close this, since really the jupyterlab side is about getting third party extensions to work.

jasongrout commented 8 years ago

(and @minrk, we'd really appreciate your input on third party extensions, #728, where the discussion is happening currently)

jasongrout commented 8 years ago

I think we should close this, since really the jupyterlab side is about getting third party extensions to work.

Or leave it open to address the UI issues... :)

ellisonbg commented 8 years ago

I actually think that JupyterHub is important enough that we should ship with support and provide a single command line flag for starting with JupyterHub support. I will begin working on this soon as I need to deploy all this in Jan...

ellisonbg commented 8 years ago

@danielballan is making progress on this...

ellisonbg commented 7 years ago

That work is here:

https://github.com/jupyterhub/jupyterhub-labextension

blink1073 commented 7 years ago

Closing as moved to https://github.com/jupyterhub/jupyterhub-labextension.