search

jupyterlab / jupyterlab

JupyterLab computational environment.
https://jupyterlab.readthedocs.io/
Other
14.07k stars 3.3k forks source link

Update `examples` folder to include localization. #8828

Open goanpeca opened 4 years ago

goanpeca commented 4 years ago

Task

After the localization work, the examples folder kept working as expected but the code does not make active use of localization.

In order to promote localizable code, it would be great to be able to showcase the bundled examples following the translation pattern.

Proposed Solution

Update the code in the examples folder to use an actual ITranslator (instead of the nullTranslator that is provided under the hood, and does nothing)

Additional context

Ping me for questions!

kgoo124 commented 4 years ago

@goanpeca I would be interested in helping out with this. I've been following the localization efforts since my time as a Cal Poly intern for the past 11 weeks, which makes this a great opportunity to learn how it works. Thank you for taking the lead on this!

goanpeca commented 4 years ago

Hi @kgoo124 thanks for your kind words. That would be great.

I will be making a Localization Call next week for people interested in the workflow and all the moving parts. Also next week Tuesday-Friday I will be exclusively making sure all the localization tools and docs are in place so this is a great time to connect.

Let's have a quick intro meeting, is Monday afternoon ok for you?

Cheers!

kgoo124 commented 4 years ago

@goanpeca I can do Monday as long as it's before 5pm PST.

goanpeca commented 4 years ago

Just sent an invite. Cheers!