search

jupyterlab / jupyterlab_pygments

Pygments theme making use of JupyterLab CSS variables
BSD 3-Clause "New" or "Revised" License
40 stars 30 forks source link

Make jupyterlab_pygments a federated labextension #11

Closed martinRenou closed 2 years ago

martinRenou commented 2 years ago

Generated from https://github.com/jupyterlab/extension-cookiecutter-ts

welcome[bot] commented 2 years ago

Thanks for submitting your first pull request! You are awesome! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly. welcome You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada:

jtpio commented 2 years ago

Thanks!

Looks like CI is not triggered on this repo? Or maybe because it's coming from a fork and the workflows are new.

jtpio commented 2 years ago

Thanks!

Looks like CI is not triggered on this repo? Or maybe because it's coming from a fork and the workflows are new.

welcome[bot] commented 2 years ago

Congrats on your first merged pull request in this project! :tada: congrats Thank you for contributing, we are very proud of you! :heart:

jtpio commented 2 years ago

Looks like you would have to rename the branch to main so CI can run.

martinRenou commented 2 years ago

Thanks that must be it indeed, I will rename it

martinRenou commented 2 years ago

Actually I don't have the rights to rename the main branch, I will update the action for now

jtpio commented 2 years ago

Just renamed to main...

martinRenou commented 2 years ago

Thanks

jtpio commented 2 years ago

Looks like CI is failing: https://github.com/jupyterlab/jupyterlab_pygments/runs/5870961151?check_suite_focus=true

martinRenou commented 2 years ago

Yes I'm looking into it and opening a new PR