jupyterlab / jupyterlab_pygments

Pygments theme making use of JupyterLab CSS variables
BSD 3-Clause "New" or "Revised" License
40 stars 30 forks source link

Upgrade extension to JupyterLab 4 #31

Closed RRosio closed 11 months ago

github-actions[bot] commented 1 year ago

Binder :point_left: Launch a Binder on branch _RRosio/jupyterlab_pygments/lab4port

jtpio commented 1 year ago

Should this PR be rebooted using the extension upgrade script? https://jupyterlab.readthedocs.io/en/latest/extension/extension_migration.html#upgrading-extension-using-the-upgrade-script

This would help pick up the latest changes to the extension template.

zaneselvans commented 1 year ago

Is there any chance of this getting revived? I do miss having decent syntax highlighting.

benz0li commented 11 months ago

Should this PR be rebooted using the extension upgrade script? https://jupyterlab.readthedocs.io/en/latest/extension/extension_migration.html#upgrading-extension-using-the-upgrade-script

This would help pick up the latest changes to the extension template.

@jtpio @RRosio It would be great if this problem was solved soon.

Can you please coordinate with each other? Thank you.

willh-cmyk commented 11 months ago

Hi, I'm happy to contribute to this, is the main issue blocking the MR from being merged the uncertainty around the release process?

krassowski commented 11 months ago

I do not think that the release process is a blocker in itself. It is more of a matter of restarting using the script: https://jupyterlab.readthedocs.io/en/latest/extension/extension_migration.html#upgrading-extension-using-the-upgrade-script and picking up any changes as made here, and ensuring the CI passes.

krassowski commented 11 months ago

Superseded by https://github.com/jupyterlab/jupyterlab_pygments/pull/38