jupyterlab / lumino

Lumino is a library for building interactive web applications
https://lumino.readthedocs.io/
Other
599 stars 127 forks source link

Add redirect from GitHub pages to RTD #362

Open krassowski opened 1 year ago

krassowski commented 1 year ago

In #358 the second copy of docs (under https://jupyterlab.github.io/lumino) was disabled. It seems that search engines seemed to prefer https://jupyterlab.github.io/lumino and these are dead links now.

It would be great to have a redirect to not loose the existing links and positioning in search engines. I explored options for doing so while writing up the issue which resulted in a commit on main branch (seriously GitHub, now actions from GUI can result in a commit without any button which says "commit"?) - sorry about this.

krassowski commented 1 year ago

It seems that the redirect is working for the main address: https://jupyterlab.github.io/lumino but old links like https://jupyterlab.github.io/lumino/signaling/interfaces/isignal.html show 404 on RTD as the URL structure is different now.

We could manually setup redirects in the RTD interface, e.g. from signaling/index.html to en/latest/api/modules/signaling.html for each of the packages (and later once search engines caught up disable these redirects).

krassowski commented 1 year ago

Happy to add the redirects manually if I can get the RTD access. Currently all three top results in Google give 404 - a bit annoying since I am still learning to navigate the refreshed API docs.

  1. https://jupyterlab.github.io/lumino/signaling/index.html (redirect to https://lumino.readthedocs.io/signaling/index.html)
  2. https://lumino.readthedocs.io/en/latest/api/signaling/globals.html
  3. https://lumino.readthedocs.io/en/latest/api/signaling/index.html

The working link (not yet indexed) is: https://lumino.readthedocs.io/en/latest/api/modules/signaling.html

Screenshot from 2022-08-21 18-13-40

blink1073 commented 1 year ago

What is your RTD username?

krassowski commented 1 year ago

krassowski. Thanks!

blink1073 commented 1 year ago

Invite sent, thank you!

krassowski commented 1 year ago

Thank you, I added redirects for (1) and (3) now.