Accessibility in accordion panel

jupyterlab / lumino

Lumino is a library for building interactive web applications

https://lumino.readthedocs.io/

Other

635 stars 126 forks source link

Accessibility in accordion panel #537

Closed brichet closed 1 year ago

brichet commented 1 year ago

This PR fixes an accessibility issue about accordion panel:

removes the role tab to the title, which is not in a tablist element.
adds an ID to the widgets if necessary, to correctly link the aria-controls attribute of the corresponding title.

brichet commented 1 year ago

I guess you use the Renderer to reuse the uuid. But could you please prefer not changing any public API and add the id if it does not exist in AccordionLayout.insertWidget - inherited from https://github.com/jupyterlab/lumino/blob/main/packages/widgets/src/panellayout.ts#L87

Thanks for review @fcollonval