search

jupyterlab / lumino

Lumino is a library for building interactive web applications
https://lumino.readthedocs.io/
Other
598 stars 127 forks source link

Make `Token.description` optional for backward compatibility #577

Closed fcollonval closed 1 year ago

fcollonval commented 1 year ago

In #572, Token.description was added but not as a optional attribute. This broke backward compatibility with 2.0.0.

This fixes it by making the description optional.

afshin commented 1 year ago

@krassowski I'm not sure I understand, should there be a change to this PR?

Otherwise, if you're happy with it, please feel free to merge.

fcollonval commented 1 year ago

Thanks @krassowski and @afshin