Added "tabindex=0" for sidebar accessibility

jupyterlab / lumino

Lumino is a library for building interactive web applications

https://lumino.readthedocs.io/

Other

598 stars 127 forks source link

Added "tabindex=0" for sidebar accessibility #583

Closed j264415 closed 1 year ago

j264415 commented 1 year ago

References #9686 and #1440

Code changes Easy part of #9686: added labels and tabindex="0" for sidebar elements so screen-readers can access them.

@krassowski Please review and comment to see if these are the right changes needed.

welcome[bot] commented 1 year ago

Thanks for submitting your first pull request! You are awesome! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly. welcome You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada:

j264415 commented 1 year ago

@meeseeksdev tag accessibility

lumberbot-app[bot] commented 1 year ago

Awww, sorry j264415 you do not seem to be allowed to do that, please ask a repository maintainer.

welcome[bot] commented 1 year ago

Congrats on your first merged pull request in this project! :tada: Thank you for contributing, we are very proud of you! :heart: