elements respond to enter or spacebar

jupyterlab / lumino

Lumino is a library for building interactive web applications

https://lumino.readthedocs.io/

Other

598 stars 127 forks source link

elements respond to enter or spacebar #590

Closed g547315 closed 11 months ago

g547315 commented 1 year ago

References https://github.com/jupyterlab/jupyterlab/issues/9686

Code changes Hard part of #9686: added functionality so elements now respond to "enters" or "spaces"on a keyboard like a link or button .

@krassowski Please review and comment

welcome[bot] commented 1 year ago

Thanks for submitting your first pull request! You are awesome! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly. welcome You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada:

g547315 commented 1 year ago

Addressing the failing test: test:firefox-headless

The changes do not affect this test as it fails with or without the changes
Error Message: 30 05 2023 14:27:53.287:ERROR [launcher]: Cannot start FirefoxHeadless XPCOMGlueLoad error for file /home/xxx-xxxx/.cache/ms-playwright/firefox-1369/firefox/libmozgtk.so: libgtk-3.so.0: cannot open shared object file: No such file or directory Couldn't load XPCOM.

As for Enforce PR label / enforce-label

Need a maintainer to label the PR (don't have permissions )

g547315 commented 1 year ago

Code changes Removed synthetic events creation Added helper method to find all adjacent child nodes Added helper method to find index of the focusedElement from adjacent child nodes Added functionality to update current Index

User-facing changes Left, right and docker panel tab bar now respond space bar and enter

Backwards-incompatible changes None

g547315 commented 1 year ago

To fix the "Does PR have API changes" test I ran the yarn run api and got this error

ERROR: Error parsing ...lumino/packages/widgets/api-extractor.json: The "mainEntryPointFilePath" path does not exist: ...lumino/packages/widgets/types/index.d.ts
I manually added the changes the command should have but the test still fails. I think it just needs someone to run the command as I am unable to

Addressing the failing test: Tests / JS (macos-latest, webkit-headless)

The Error: WebkitHeadless stderr: /home/ec2-user/.cache/ms-playwright/webkit-1751/minibrowser-wpe/bin/MiniBrowser: error while loading shared libraries: libgstreamer-1.0.so.0: cannot open shared object file: No such file or directory
The changes do not affect this test as it fails with or without the changes

fcollonval commented 11 months ago

@g547315 thanks for pushing this. I took the liberty to push some simplification to push this PR through the finish line. Would you mind having a look to my changes?

brichet commented 11 months ago

Thanks @g547315 for working on this, this look good to me.

(Probably for a follow up PR) I was thinking about the same issue before seeing this PR, and I'm wondering if having the tabindex="0" on each tab is the right approach. It should be better to switch from one tab to another using the arrow keys instead of using tabulation. If you have a lot of tabs opened, it can be very annoying to move out of the tabbar.

Maybe a better solution could be:

to have the tabindex="0" only to the selected tab, and tabindex="-1" on the other ones
to catch the left/right/top/down arrow to switch the selected tabs (and the tabindex values)

Like that, using the tabulation will move the focus on another widget than the tabbar.

welcome[bot] commented 11 months ago

Congrats on your first merged pull request in this project! :tada: Thank you for contributing, we are very proud of you! :heart: