Upgrade dev dependencies

jupyterlab / lumino

Lumino is a library for building interactive web applications

https://lumino.readthedocs.io/

Other

598 stars 127 forks source link

Upgrade dev dependencies #599

Closed fcollonval closed 11 months ago

fcollonval commented 1 year ago

Bump:

Typescript 4.9 -> 5.1
Yarn 3.4 -> 3.6.
Lerna 6.3 -> 7.1
Prettier 2.7 -> 3
typedoc 0.23 -> 0.24

fcollonval commented 1 year ago

I think it is safe to bump TypeScript from 4.9 t 5.1. But as we had issue before while bumping TypeScript, I would appreciate thoughts from other devs.

cc @jupyterlab/jupyterlab-council

echarles commented 1 year ago

I guess yarn and lerna deserve a bunch of attention also. My feedbacks

CI should ideally be green and stable (now failing on Tests/build)
I have tested on my local env with yarn, yarn build and yarn test and it works fine
Most important, JupyterLab should be aligned with those changes. Any PR for that?

jtpio commented 1 year ago

I think it is safe to bump TypeScript from 4.9 t 5.1. But as we had issue before while bumping TypeScript, I would appreciate thoughts from other devs.

This PR may be relevant for the TypeScript 5.1 update: https://github.com/jupyterlab/jupyterlab/pull/14638

fcollonval commented 1 year ago

CI should ideally be green and stable (now failing on Tests/build)

:+1: CI is greener (failing test are due to flakiness)

Most important, JupyterLab should be aligned with those changes. Any PR for that?

@echarles would you mind giving more details about your thinking here? I don't see the reasons for dev deps alignement between Lab and Lumino (it has almost never been true in the past).

FYI I computed the diff for the types of @lumino/widgets between main and this PR:

diff --color packages/widgets/types/index.d.ts packages/widgets/types.bak/index.d.ts
0a1,4
> /**
>  * @packageDocumentation
>  * @module widgets
>  */
Only in packages/widgets/types.bak: tsdoc-metadata.json

The only change is the documentation addition by this PR. So it seems we will avoid the trouble hit in the past.

echarles commented 1 year ago

@echarles would you mind giving more details about your thinking here? I don't see the reasons for dev deps alignement between Lab and Lumino (it has almost never been true in the past).

I sometimes had to develop in both lumino and jupyterlab source base (one depending on the other).

That's fine if it is not the case, it will just make life a bit harder some days.