Closed DenisaCG closed 1 year ago
Thanks for submitting your first pull request! You are awesome! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada:
Thanks for the review @fcollonval! I applied the suggested cosmetic changes and added the index of the widget for the signal to provide.
The remaining API failure is relevant and due to the extraction of the public API. To solve it, the command yarn && yarn build && yarn api
must be run locally and then the changes must be committed.
I did it in 841237e
The remaining API failure is relevant and due to the extraction of the public API. To solve it, the command
yarn && yarn build && yarn api
must be run locally and then the changes must be committed.I did it in 841237e
Oh okay, that makes sense. Thank you @fcollonval!
Congrats on your first merged pull request in this project! :tada: Thank you for contributing, we are very proud of you! :heart:
Added an
expansionToggled
signal to theAccordionPanel
class that gets triggered when an element from theAccordionPanel
is collapsed or expanded.The signal makes it useful for saving the layout of the sidebars, including the expansion status of all subpanels, such that once the user collapses a subpanel for example, the layout saves that information for later restoration.