search

jupyterlab / lumino

Lumino is a library for building interactive web applications
https://lumino.readthedocs.io/
Other
596 stars 127 forks source link

Add expansion toggled signal of subpanels in an Accordion Panel #614

Closed DenisaCG closed 11 months ago

DenisaCG commented 11 months ago

Added an expansionToggled signal to the AccordionPanel class that gets triggered when an element from the AccordionPanel is collapsed or expanded.

The signal makes it useful for saving the layout of the sidebars, including the expansion status of all subpanels, such that once the user collapses a subpanel for example, the layout saves that information for later restoration.

welcome[bot] commented 11 months ago

Thanks for submitting your first pull request! You are awesome! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly. welcome You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada:

DenisaCG commented 11 months ago

Thanks for the review @fcollonval! I applied the suggested cosmetic changes and added the index of the widget for the signal to provide.

fcollonval commented 11 months ago

The remaining API failure is relevant and due to the extraction of the public API. To solve it, the command yarn && yarn build && yarn api must be run locally and then the changes must be committed.

I did it in 841237e

DenisaCG commented 11 months ago

The remaining API failure is relevant and due to the extraction of the public API. To solve it, the command yarn && yarn build && yarn api must be run locally and then the changes must be committed.

I did it in 841237e

Oh okay, that makes sense. Thank you @fcollonval!

welcome[bot] commented 11 months ago

Congrats on your first merged pull request in this project! :tada: congrats Thank you for contributing, we are very proud of you! :heart: