search

jupyterlab / lumino

Lumino is a library for building interactive web applications
https://lumino.readthedocs.io/
Other
596 stars 127 forks source link

Added role of button to addButton to make itkeyboard accessible when using screenreader #615

Closed s596757 closed 11 months ago

s596757 commented 11 months ago

Issue number: 14814

https://github.com/jupyterlab/jupyterlab/issues/14814

In order to make the the addLauncher button keyboard accessible when using screen reader, added the role of button to the div element.

Tested using windows narrator. The add button is now keyboard accessible with screen reader and without it. In order to launch new launcher via keyboard: use Enter key or Spacebar Key.

fcollonval commented 11 months ago

Thanks @s596757

As #612 added some feature on the tab bar, I rebased this PR. Would you mind giving it a try to confirm it is still fixing the issue?

s596757 commented 11 months ago

Thanks @s596757

As #612 added some feature on the tab bar, I rebased this PR. Would you mind giving it a try to confirm it is still fixing the issue?

Yes this is still working on my end

welcome[bot] commented 11 months ago

Congrats on your first merged pull request in this project! :tada: congrats Thank you for contributing, we are very proud of you! :heart: