search

jupyterlab / lumino

Lumino is a library for building interactive web applications
https://lumino.readthedocs.io/
Other
596 stars 127 forks source link

Keydown event at bubbling phase #635

Closed brichet closed 9 months ago

brichet commented 9 months ago

This PR adds an experimental parameter when starting application to handle the keydown event at bubbling phase.

Currently the keydown events are handled at capture phase. With this PR it with possible to switch from capture to bubbling at startup.

See https://github.com/jupyterlab/jupyterlab/pull/14115#issuecomment-1727686379 for context.

cc. @fcollonval @krassowski @gabalafou

brichet commented 9 months ago

Thanks for your quick review @fcollonval @krassowski. I have addressed your suggestions.

krassowski commented 9 months ago

Sounds great, thank you!

fcollonval commented 9 months ago

Merging this and doing an alpha release