search

jupyterlab / lumino

Lumino is a library for building interactive web applications
https://lumino.readthedocs.io/
Other
635 stars 126 forks source link

Close launcher button styling and close launcher with delete key #655

Open e218736 opened 1 year ago

e218736 commented 1 year ago

References

#15303 - Issue no. 3 - Arrow key navigation between launcher tabs not as expected #15347 - Change close launcher div to button for screen reader accessibility

When screen reader is active, pressing caps lock + right arrow key lands on close launcher div but does not close on Enter.

Accessibility documentation states an optional keyboard interaction where, if deletion is allowed, pressing "Delete" closes the current tab element and its associated tab panel

Code changes

Changed styling of close launcher to original after div has been changed to button (in PR 15347) Enabling focused tab to be closed using "Delete" on keyboard

welcome[bot] commented 1 year ago

Thanks for submitting your first pull request! You are awesome! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly. welcome You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada:

gabalafou commented 1 year ago

Also, please update the PR description. It's currently a (near) duplicate of https://github.com/jupyterlab/jupyterlab/pull/15347

krassowski commented 8 months ago

@gabalafou I see that you mentioned this PR in https://github.com/jupyterlab/jupyterlab/pull/15347. Once this is ready I am happy to merge and release but currently your review is blocking here:

image