search

jupyterlab / pull-requests

A JupyterLab extension for reviewing GitHub pull requests
BSD 3-Clause "New" or "Revised" License
37 stars 18 forks source link

Support legacy notebook launcher #48

Closed fcollonval closed 3 years ago

fcollonval commented 3 years ago

Extracted from #44

codecov-commenter commented 3 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@02e2cbd). Click here to learn what that means. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #48   +/-   ##
=========================================
  Coverage          ?   61.02%           
=========================================
  Files             ?       34           
  Lines             ?     1647           
  Branches          ?       94           
=========================================
  Hits              ?     1005           
  Misses            ?      637           
  Partials          ?        5
Impacted Files Coverage Δ
jupyterlab_pullrequests/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 02e2cbd...75badfc. Read the comment docs.

bollwyvl commented 3 years ago

Cool thanks for cleaning up some of the unbundling. When next I get a chance I'll merge into #44 and see what's still hanging out, maybe it can actually land with the anonymous provider... Someday!