search

jupyterlab / pull-requests

A JupyterLab extension for reviewing GitHub pull requests
BSD 3-Clause "New" or "Revised" License
37 stars 18 forks source link

Integrate with jupyterlab-github #6

Open ian-r-rose opened 5 years ago

ian-r-rose commented 5 years ago

I think there are some opportunities here to integrate this with @jupyterlab/github and have a more unified experience for users. I haven't really thought it all through, but some ideas could involve:

  1. Opening the branch-in-question in the GitHub filebrowser for looking at the un-diffed files.
  2. Unified handling of API tokens on the server side.
  3. Launch @jupyterlab/pull-requests from the GitHub filebrowser.
jaipreet-s commented 5 years ago

Thanks @ian-r-rose . I agree with all of these.

Launch @jupyterlab/pull-requests from the GitHub filebrowser.

I've been thinking of how to do this for other extensions as well. What's the recommended way for an extension to trigger the some functionality in another extension?