jupyterlite / cockle

In-browser bash-like shell implemented in TypeScript.
BSD 3-Clause "New" or "Revised" License
3 stars 2 forks source link

Support separate WASM/JS files and remove use of callMain #44

Closed ianthomas23 closed 2 months ago

ianthomas23 commented 2 months ago

With the merging of emscripten-forge/recipes#1278 there are now the following packages on Emscripten-forge with separate JS and WASM files:

This PR uses these new WASM files, most of the changes for this are trivial as the work has already been done and importScripts automagically works for the .wasm files provided they are served from the same directory as the .js files.

The other changes are to deal with not having to call callMain anymore, the calls happens automatically when a JS/WASM Module is instantiated.

I have changed the playwright test settings to run a single test at a time as without it there were some problems with multiple tests trying to load JS/WASM files at the same time. It is probably just my limited understanding of playwright, but as the tests only take ~15 seconds to run this is fine for now and can be revisited later.

After this I plan to release version 0.0.6 and bring the JupyterLite terminal extension up to date to use it.