jupyterlite / javascript-kernel

A simple JavaScript kernel for JupyterLite, running in a Web Worker
https://jupyterlite.github.io/javascript-kernel/
BSD 3-Clause "New" or "Revised" License
4 stars 4 forks source link

0.3.0 does not depend on `jupyterlite-core` #15

Open bollwyvl opened 2 months ago

bollwyvl commented 2 months ago

Description

This does not have PEP 621 dependencies on jupyterlite-javascript-kernel

Reproduce

Given:

# environment.yml
channels: [conda-forge]
dependencies:
- python
- pip
- pip:
  - jupyterlite-javascript-kernel

Then

mamba upgrade --file environment.yml --prefix .venv
source activate .venv
pip list | grep jupyter

See:

jupyterlite_javascript_kernel 0.3.0

Expected behavior

jupyter_core x.x.x
jupyterlite-core 0.3.0
jupyterlite_javascript_kernel 0.3.0

Context

jtpio commented 2 months ago

Do we need the dependency on jupyterlite-core, if there is no JupyterLite addon? (similar to JupyterLab extension which which usually don't have a dependency on jupyterlab)

bollwyvl commented 2 months ago

Welp... in theory that would work, but in practice (as there are no tests here) we're basically punting it to the site owner, or worse, a site user, to test whether a given configuration works. Indeed, lab at least has jupyter labextension list which would make it abundantly clear when things aren't going to work.

We can't really make a package more core than jupyterlite-core on which to advertise the liteserverextension/kernel API.

We could make another jupyterlite/matrix or something that tried to build demo sites of lots of extensions against lots of versions... but this would be a pretty unsatisfying site to visit, given the amount of issues with e.g. serviceworker registration.