jupyterlite / jupyterlite-sphinx

Sphinx extension using JupyterLite to render Notebooks
https://jupyterlite-sphinx.readthedocs.io/en/latest
BSD 3-Clause "New" or "Revised" License
68 stars 21 forks source link

Raise informative error message when building man on older sphinx #158

Closed Carreau closed 7 months ago

Carreau commented 8 months ago

This will make the case of building manpages with earlier sphinx fail with an informative error message

ValueError: Two different values of iframe_src attributes["iframe_src"]='lite/repl/index.html?kernel=xeus-python&toolbar=0&theme=JupyterLab%20Light&code=print%28%22Hello%20from%20a%20JupyterLite%20console%21%22%29',iframe_src='lite/repl/index.html', try upgrading sphinx to v 7.2.0 or more recent

Closes #117

As noted in the issue, we could pin sphinx to >7.2, but is it really necessary if it only affects man pages ?