jupyterlite / jupyterlite

Wasm powered Jupyter running in the browser 💡
https://jupyterlite.rtfd.io/en/stable/try/lab
BSD 3-Clause "New" or "Revised" License
3.76k stars 286 forks source link

Can't see URLs in rendered Markdown cells; linkification fails #1334

Open westurner opened 4 months ago

westurner commented 4 months ago

Description

Markdown rendering of bare URLs https://example.org/ and URLs without anchor text [](https://example.org/ has breakingly changed.

When I paste the below text into a Markdown cell in JupyterLite, (1) it does not linkify the first two URLs; and (2) I can't see the text of the second two URLs as Markdown works in all other implementations.

Is there a way to turn off the new hover cards and make pasting URLs into Markdown cells result in <a hrefs again?

Reproduce

  1. Create a Markdown cell with the following text and Ctrl-Enter:
    
    - https://en.wikipedia.org/wiki/Exploratory_data_analysis
    - https://en.wikipedia.org/wiki/Variance

Expected behavior

When I paste a bare URL in Markdown, I should be able to read the full URL in the rendered HTML (without hovering over each link, which is impossible on mobile and not Accessible)

Context

Browser Output
Paste the output from your browser Javascript console here.

Screenshot from 2024-03-02 20-56-14 Screenshot from 2024-03-02 20-57-50

jtpio commented 4 months ago

Thanks @westurner for the report.

Could it be an issue with jupyterlab-myst?

The latest version of the demo does not include jupyterlab-myst anymore, because there were some issues with the rendering of the Mermaid diagram: https://github.com/jupyterlite/jupyterlite/pull/1263

And it seems to be behaving fine:

image

westurner commented 4 months ago

Looks like it works in a Private Window but not with whatever I have cached.

What it did before I Shift-Ctrl-R refreshed:

Screenshot from 2024-03-26 17-16-03

What is does now:

Screenshot from 2024-03-26 17-20-50