search

jupyterlite / jupyterlite

Wasm powered Jupyter running in the browser 💡
https://jupyterlite.rtfd.io/en/stable/try/lab
BSD 3-Clause "New" or "Revised" License
3.92k stars 312 forks source link

Fix workflow to update the playwright snapshots #1479

Closed jtpio closed 2 months ago

jtpio commented 2 months ago

Noticed in https://github.com/jupyterlite/jupyterlite/actions/runs/10774644110/job/29891126510, the workflow does not seem to be able to push the update images

Artifact playwright-report-firefox.zip successfully finalized. Artifact ID 1910580175
Artifact playwright-report-firefox has been successfully uploaded! Final size is 291347 bytes. Artifact ID is 1910580175
Artifact download URL: https://github.com/jupyterlite/jupyterlite/actions/runs/10774644110/artifacts/1910580175
Run git config user.name 'github-actions[bot]'
From https://github.com/jtpio/jupyterlite
 * branch            ui-tests-fix -> FETCH_HEAD
Already up to date.
On branch ui-tests-fix
nothing to commit, working tree clean
Error: Process completed with exit code 1.

image

Also the snapshots artifacts contain the snapshots for both browsers, while they should only contain the snapshots for the browser passed via --browser {{ matrix.browser }}:

image

jtpio commented 2 months ago

This is likely because the workflow does not perform any update to the snapshots. https://github.com/jupyterlite/jupyterlite/pull/1477 fixes how the extra packages are installed for the UI tests and should fix it.