search

jupyterlite / litegitpuller

nbgitpuller in JupyterLite
BSD 3-Clause "New" or "Revised" License
2 stars 4 forks source link

Remove playwright browser installation #12

Open brichet opened 1 year ago

brichet commented 1 year ago

Follow https://github.com/jupyterlite/litegitpuller/pull/11

Playwright browser are not automatically installed since v1.38.0.

This broke the build test, because jupyterlab/check_browser does not install it too.

This has been fixed in https://github.com/jupyterlite/litegitpuller/pull/11, but the fix should be removed as soon as the jupyterlab/check_browser installs the browser.

jtpio commented 1 year ago

the fix should be removed as soon as the jupyterlab/check_browser installs the browser.

Should we track or directly fix this upstream in JupyterLab?

brichet commented 1 year ago

No sure to understand your question. We should fix it, but then wait for a release and a backport to v3.5.

jtpio commented 1 year ago

I meant opening an issue in https://github.com/jupyterlab/jupyterlab.

Or directly fix this in https://github.com/jupyterlab/jupyterlab as a PR.

brichet commented 1 year ago

I opened https://github.com/jupyterlab/jupyterlab/issues/15116 and I'm testing a change locally to open a PR.