search

jupyterlite / pyodide-kernel

Python kernel for JupyterLite powered by Pyodide
https://jupyterlite-pyodide-kernel.readthedocs.io/en/latest/_static/
BSD 3-Clause "New" or "Revised" License
46 stars 25 forks source link

FileSystem calls over Atomics.wait instead of service worker when available #114

Closed martinRenou closed 5 months ago

martinRenou commented 5 months ago

This has the implication of moving from using comlink to using coincident for the Main <-> Worker communcication

github-actions[bot] commented 5 months ago

lite-badge :point_left: Try it on ReadTheDocs

martinRenou commented 5 months ago

Oh there are no visual regression tests testing the code execution. That makes me uncomfortable :)

martinRenou commented 5 months ago

Well at least we have the readthedocs build for trying

martinRenou commented 5 months ago

Let's get https://github.com/jupyterlite/pyodide-kernel/pull/115 in first

bollwyvl commented 5 months ago

On RTD, this still demonstrates https://github.com/jupyterlite/jupyterlite/issues/1412 .

If that gets fixed over there, we need that to land a PR and ship another beta there before this can be reviewed.

If this is going to get fixed on this side, it has to happen either on a separate PR, or on this PR, before it can be properly reviewed.

martinRenou commented 5 months ago

I can't seem to be able to reproduce what you're seeing on this RTD build

Screenshot from 2024-06-17 15-00-17

jtpio commented 5 months ago

I can't seem to be able to reproduce what you're seeing on this RTD build

https://github.com/jupyterlite/jupyterlite/issues/1412 mentions the build on the JupyterLite repo, which likely uses an old release of jupyterlite-pyodide-kernel. In that case using https://jupyterlite--1383.org.readthedocs.build/en/1383/_static/lab/index.html I can also reproduce the error:

image

Could it be because that RTD demo uses the latest JupyterLite, but an older jupyterlite-pyodide-kernel. If so, wouldn't that be fixed with the JupyterLite 0.4.0 and jupyterlite-pyodide-kernel 0.4.0 final releases? (as with this PR)

bollwyvl commented 5 months ago

Welp, i'm getting 100% repro of the above issue on linux/chromium 126.0.6478.61, in and out of an incognito window.

image

We know it won't work in FF private, but also seeing in firefox 127.0:

image

martinRenou commented 5 months ago

I've looked deeper into it, I believe https://github.com/jupyterlite/jupyterlite/pull/1418 should fix it. Can you give it a try? I see it working there

jtpio commented 5 months ago

FYI @bollwyvl 0.4.0b0 is out with this change: https://github.com/jupyterlite/pyodide-kernel/releases/tag/v0.4.0b0

If that looks good to you, we can likely move forward with JupyterLite 0.4.0 and release final in the coming days.

bollwyvl commented 5 months ago

Won't be able to review much this weekend, but will roll it on conda-forge and see what we get...