search

jupyterlite / xeus-python-kernel

xeus-python in JupyterLite
https://xeus-python-kernel.readthedocs.io
BSD 3-Clause "New" or "Revised" License
30 stars 19 forks source link

Update to `check-release@v2` #113

Closed jtpio closed 1 year ago

jtpio commented 1 year ago

Investigate releaser workflow failures: https://github.com/jupyterlite/xeus-python-kernel/actions/runs/4185862759

jtpio commented 1 year ago

I think releaser v2 has an issue with not reading the config from package.json if pyproject.toml exists.

But this PR moves the config to pyproject.toml anyway and the check now passes.

jtpio commented 1 year ago

Maybe a follow-up could be to migrate to hatch if we want to streamline the setup more.

jtpio commented 1 year ago

I'll proceed with the merge and follow-up with a new release to double check it fixes it.

jtpio commented 1 year ago

All good now: https://github.com/jupyterlite/xeus-python-kernel/releases/tag/v0.6.3

I had to update the NPM_TOKEN which was probably wrong, and reran the "Publish Release" workflow.

martinRenou commented 1 year ago

Thanks!