jupyterlite / xeus-python-kernel

xeus-python in JupyterLite
https://xeus-python-kernel.readthedocs.io
BSD 3-Clause "New" or "Revised" License
30 stars 19 forks source link

Pin xeus-python to a known working version #129

Closed martinRenou closed 1 year ago

martinRenou commented 1 year ago

cc. @DerThorsten

We should eventually make this constraint softer in the future ">=0.16,<0.17" and make minor releases when the WASM API change

github-actions[bot] commented 1 year ago

lite-badge :point_left: Try it on ReadTheDocs

jtpio commented 1 year ago

Maybe another way could be to mark the latest xeus python as broken on conda forge, and re-release it with the correct version bump?

martinRenou commented 1 year ago

Do we have a way to mark recipes as broken on emscripten-forge? If yes, that could be another way to fix the immediate issue indeed.

But I think we should pin xeus-python in jupyterlite-xeus-python in the long run anyway, or at least put a constraint on it, because jupyterlite-xeus-python needs to use a version of xeus-python that is compatible with the empack version. Only jupyterlite-xeus-python can do this.

jtpio commented 1 year ago

mark recipes as broken on emscripten-forge?

Ah right, not sure about this.

But yeah actually pinning sounds like the simpler solution for now.

martinRenou commented 1 year ago

Ok! Merging and releasing this