search

jupyterlite / xeus-python-kernel

xeus-python in JupyterLite
https://xeus-python-kernel.readthedocs.io
BSD 3-Clause "New" or "Revised" License
30 stars 19 forks source link

Add support for environment.yml file #96

Closed martinRenou closed 1 year ago

martinRenou commented 1 year ago

Fix https://github.com/jupyterlite/xeus-python-kernel/issues/53

nthiery commented 1 year ago

Nice! I did not expect it to come so soon; thank you @martinRenou. Eager to try it.

Do you have some tentative timeline for when pip support might be added?

martinRenou commented 1 year ago

Do you have some tentative timeline for when pip support might be added?

Probably pure Python packages could simply be installed with pip and it might just be a matter of removing the check I added here and find the proper way to pass them to micromamba/mamba/conda. I would need to give it a try :)

I don't see any reason for pure Python packages to not work if installed with pip, I added the check because I'm not sure how to handle the non-pure packages, how to track them and show a nice error message at build time. Maybe we could just let it fail at runtime, though it would probably prevent the kernel to start without any feedback to the user.

nthiery commented 1 year ago

Thanks for the quick feedback! My use cases are plain Python indeed. I'll experiment with it in January by removing the check in the source (or even simpler if there can be an enable-pip experimental option?).