search

jupyterlite / xeus

JupyterLite loader for Xeus kernels
https://jupyterlite-xeus.readthedocs.io
BSD 3-Clause "New" or "Revised" License
22 stars 12 forks source link

Use `coincident` if `crossOriginIsolated`, `comlink` otherwise #108

Closed jtpio closed 2 months ago

jtpio commented 3 months ago

Similar to https://github.com/jupyterlite/pyodide-kernel/pull/126

Refactor the code to align the implementation on https://github.com/jupyterlite/pyodide-kernel, so it's easier to switch between the code bases and find the same patterns.

Fixes https://github.com/jupyterlite/xeus/issues/102

jtpio commented 3 months ago

Looks like the use of postMessage in xeus-lite may need some investigation: https://github.com/jupyter-xeus/xeus-lite/blob/b1c9e1fd29caa88e7ebb2dd06c798c248ed01b0c/src/xserver_emscripten.cpp#L24-L32

martinRenou commented 2 months ago

@jtpio this should be ready now. Would you be able to have another look?

martinRenou commented 2 months ago

@jtpio thanks for your review! I added the comment as you suggested, will go ahead and make a release with this

jtpio commented 2 months ago

It would also have been nice to mention this change in the changelog for visibility: https://jupyterlite-xeus.readthedocs.io/en/latest/changelog.html

For the docs, there is already some content https://jupyterlite.readthedocs.io/en/stable/howto/content/python.html we could link to.