search

jupyterlite / xeus

JupyterLite loader for Xeus kernels
https://jupyterlite-xeus.readthedocs.io
BSD 3-Clause "New" or "Revised" License
22 stars 11 forks source link

update README.md with JupyterLite site instructions #25

Closed Vipul-Cariappa closed 8 months ago

Vipul-Cariappa commented 8 months ago

Look at https://github.com/jupyter-xeus/xeus/issues/377#issuecomment-1883041231

martinRenou commented 8 months ago

Thanks! @Vipul-Cariappa

It seems you're not getting credits for your changes in Github UI. You are creating your commits with an email address ending with @.com (see https://github.com/jupyterlite/xeus/commit/078cc6f641bb241bc9953fef7b5e5b904af4603a.patch).

It seems it's not a valid email address? This may be fine if you add this address to your Github account https://github.com/settings/emails (no need to verify your email address for Github to consider the commits coming from this address to be yours). Though you may want to fix this in your git config and provide a real address.

Vipul-Cariappa commented 8 months ago

@martinRenou, Thanks for pointing out that my email configured is wrong. I have fixed it using git config --global user.email "vipulcariappa@gmail.com". Any commits in the future should work fine.

Vipul-Cariappa commented 8 months ago

Hope the failing test is not my doing?