search

juraj-hrivnak / Greenery

Minecraft Forge mod that makes the world more green and lively by adding new plants.
https://juraj-hrivnak.github.io/Greenery/
MIT License
9 stars 3 forks source link

Fluidlogging Not Working #5

Closed Desoroxxx closed 2 years ago

Desoroxxx commented 2 years ago

Greenery Version: 1.12.2-2.0 Fluidlogged API Version: v1.8.1d-mc1.12.2

image

juraj-hrivnak commented 2 years ago

Any other mods you use with it? It works fine for me.

Desoroxxx commented 2 years ago

After investigation, I can confirm two things:

juraj-hrivnak commented 2 years ago

There must’ve been some changes that broke it. I will try to fix it in the new update. Thanks for the report!

jbredwards commented 2 years ago

The only thing I did between updates was improve the config and remove unnecessary neighbor fluid block updates, so this is probably an issue with Fluidlogged API's chunk capabilities. For whatever reason I can't figure out how to get them load from save data properly (server-side nor client-side), adding this magically got them to load client-side and server-side (genuinely no clue how), since then I've just kinda ignored the problem, I'll look into it again once I finish up the njarm2 rewrite. In the meantime you can try queuing neighbor fluid block updates when the kelp generates and see if that works, this will cause the water to flow into the kelp when the world is loaded, this is probably what was happening before so it should be fine for now.

juraj-hrivnak commented 2 years ago

@JustDesoroxxx I can't reproduce it. Can you try it again with Fluidlogged API v1.8.1e?

juraj-hrivnak commented 2 years ago

I am closing it because I can not reproduce it, and the issue is stale.