search

juraj-hrivnak / Pakku

A multiplatform modpack manager for Minecraft: Java Edition. Create modpacks for CurseForge, Modrinth or both simultaneously.
https://juraj-hrivnak.github.io/Pakku/
European Union Public License 1.2
24 stars 4 forks source link

Do not resolve dependencies on import (by default) #16

Closed Wxrlds closed 3 months ago

Wxrlds commented 3 months ago

Currently, when importing a modpack, it resolves dependencies.

I think this shouldn't be the default behaviour for various reasons:

  1. When importing a project, I generally want it to be just as it was published, not with modified dependencies
  2. The bigger issue is that mods like Had Enough Items, Extended Crafting: Nomifactory Edition and a lot more exist, which are maintained forks of various big mods, but for older game versions. Usually, the big mods are referenced in the dependencies of other mods, which causes issues if a modpack ships the fork, instead of the original mod.

Additionally, someone might actually want to resolve dependencies, that's why there now is a --deps/-D switch, which resolves dependencies, just like it did before.

Another option would be to keep the default behaviour and invert the switch, but as stated, I think the default should be changed.

juraj-hrivnak commented 3 months ago

Hello, thanks for the PR!

I think this is a good change for now. Resolving dependencies will be reworked one day so that it collects all dependencies of all projects and creates one batched HTTP request.

Can you also add a reference to the flag in the docs?