juraj-hrivnak / Underdog

A complete overhaul of Minecraft's survival mode with an emphasis on realism and ecology.
https://www.curseforge.com/minecraft/modpacks/underdog
GNU General Public License v3.0
17 stars 5 forks source link

Tweaked petroleum config required #34

Closed Srdjan-V closed 2 years ago

Srdjan-V commented 2 years ago

By default Tweaked petroleum removes IP reservoir loading, this is intended behavior but was poorly expand. The cf page has be updated to reflect that and i have created a starting template, the configs are equivalent to IP's

juraj-hrivnak commented 2 years ago

Thanks for the report, (and making the mod.) I will add the config for the next update.

Srdjan-V commented 2 years ago

Than you for using it. I aslo wanted to tell you to make the update quickly, since without the reservoirs being loaded all chunks with fluid chunks will be lost on world load, or tell the players to disable the overwrites in the config (that way the chunks will not be lost, but the will also not be usable)

juraj-hrivnak commented 2 years ago

Oh, so only newly generated chunks will have reservoirs or some chunks will get corrupted after the change? I hope it’s not the second option.

Srdjan-V commented 2 years ago

Not exactly, IP has a way of loading reservoirs through its config. Witch, I have disabled because those configs do not include the additional data I have added (and for consistency). The way I have set it out to be is so that you add the reservoirs through zenscript. But if you do not add the reservoirs all chunks that have a fluid chunk will be lost. Since the game does not know what fluid should be in that chunk. If that hapens the best option is to delete the data for fluid chunks, save/data/immersivepetroleum.data

But as for compatability its fully compatible with the allredy generated reservoirs if you register them with the same name(like in the template i made).

juraj-hrivnak commented 2 years ago

Ah, make sense! Thanks for the information. I will release the fix as soon as possible.