juranki / sveltekit-cdk

Tools for deploying SvelteKit to AWS using CDK
https://juranki.github.io/sveltekit-cdk/
MIT License
31 stars 5 forks source link

Binary request/response body #15

Closed juranki closed 2 years ago

juranki commented 2 years ago

Implement transformations

https://github.com/juranki/sveltekit-cdk/blob/main/packages/adapter/src/files/util.ts#L27-L32 https://github.com/juranki/sveltekit-cdk/blob/main/packages/adapter/src/files/at-edge-handler.ts#L87-L97

steffenstolze commented 2 years ago

What would be a typical scenario for binary request / response bodies? I can imagine file uploads or downloads but would consider S3 for those things?

Thank you! :)

juranki commented 2 years ago

Scenarios that require binary are not common, but they do occur.

Granted, Lambda@Edge payload size limit can be difficult in many cases with binary content. But I still feel the adapter is severely incomplete if it only supports text body.