jurassix / react-validation-mixin

Simple validation mixin (HoC) for React.
MIT License
283 stars 38 forks source link

Validation improved by validating single field if there is a key def… #29

Closed dorumd closed 9 years ago

dorumd commented 9 years ago

…ined. When there are a lot of fields in form validation starts to be slowly.

dorumd commented 9 years ago

@jurassix Case when field that should be validated has refs fixed. I'm not sure if a ref could have other child refs. If yes, we could easy check and add recursive each ref value and validation schema. Any other special cases?

jurassix commented 9 years ago

I'm currently in the middle of major release of this library; should be this week. I don't see any merge issues with these changes yet. I'll need to play with this PR, add some tests, and maybe add a perf test too. If you want to handle testing then please do, otherwise I'll merge this into next release.

jurassix commented 9 years ago

Code has diverged greatly from 4.x to 5.x

I'm still planning on putting together perf tests to get some data before accepting this PR. In the interim please make changes in the new joi-validation-strategy repo here.