search

jure / aframe-blink-controls

A teleport (blink with rotation) component for A-Frame
https://jure.github.io/aframe-blink-controls
MIT License
50 stars 17 forks source link

Rename PlaneBufferGeometry to PlaneGeometry #20

Closed vincentfretin closed 2 years ago

vincentfretin commented 2 years ago

Rename PlaneBufferGeometry to PlaneGeometry to remove warning in threejs r144 used in current aframe master.

PlaneBufferGeometry was renamed to PlaneGeometry a while ago but in threejs r144 they added a warning "THREE.PlaneBufferGeometry has been renamed to THREE.PlaneGeometry.", see https://github.com/mrdoob/three.js/commit/5acd8ce2cfb7fc29b4fde9775e46041ace9bc055

If did a similar fix recently in aframe https://github.com/aframevr/aframe/pull/5114

vincentfretin commented 2 years ago

When I say a while ago, it was around aframe 1.2.0 threejs r125, this was already the case https://github.com/supermedium/three.js/blob/super-r125-1/src/geometries/PlaneGeometry.js#L81 so I think this is safe to merge.

jure commented 2 years ago

Thank you, @vincentfretin!

vincentfretin commented 2 years ago

When you have some time, can you please do a bugfix release with the change? Thanks.

jure commented 2 years ago

Thanks again, @vincentfretin! Released as version 0.4.1.