jurialmunkey / plugin.video.themoviedb.helper

GNU General Public License v3.0
205 stars 96 forks source link

[BUG] Artwork english fallback not working anymore #1279

Closed smokyy12 closed 20 hours ago

smokyy12 commented 2 days ago

Describe the bug

I use TMBD-Helper in german with fanart.tv api-key and it used to give me clear art titles for every movie and show when i enabled the fallback to english option in settings. now it stopped working on all my devices and different kodi setups and only gives me clear art when there is german available. when i set tmdb helper to english i get clear art for every movie and show. Maybe you can help, thx in advance

Steps To Reproduce

Set tmdb language to german --> no clear art, even with fallback to english setting Set i back to english --> clear art is there

Debug log

No response

Screenshots and Additional Info

No response

Checklist

jurialmunkey commented 2 days ago

I haven't changed the code handling the artwork selection in a long time.

Do you have examples of how I can recreate this issue to test?

smokyy12 commented 2 days ago

Yes, set your tmdb-helper metadata language to german and see if you get clear art titles for movies and shows. i find it very strange too, i use arctic horizon 2 and arctic fuse on 3 devices. i noticed that the clear art was gone on my pc setup, then i turned on my shield tv where kodi was still open, closed and reopened kodi and clear art was also gone there. maybe its a problem with fanart.tv api if you havent changed anything? i also created a new api key and tested, no success.

jurialmunkey commented 2 days ago

Please give me examples of specific movies titles to test with.

smokyy12 commented 2 days ago

Oh sorry, i misunsterstood. For example the show „mr. robot“ has no clear art in german, in english it works. Same for „Reacher“. For „Rings of Power“ i still get clear art in german, i think its because theres a translated title „Ringe der Macht“.

jurialmunkey commented 1 day ago

Both work fine for me in TMDbHelper

screenshot00879

screenshot00881

Screenshot 2024-11-12 103740

Screenshot 2024-11-12 103714

matke-84 commented 1 day ago

I have written before about similar problems. https://github.com/jurialmunkey/plugin.video.themoviedb.helper/issues/1181

jurialmunkey commented 1 day ago

I have written before about similar problems. #1181

This sounds like a different matter.

Either way, without reproducible examples it is difficult for me to fix.

From the examples provided here I cannot reproduce the issue. As seen in my screenshots, it appears to be working correctly.

smokyy12 commented 1 day ago

Thx for checking, it seems like the problem is somewhere on my side if its working for you. As i stated earlier, it used to work without a problem for years and stopped working now on three different devices from one second to another without changing anything. maybe its some network related problem on my side. If a log would help you i will see to upload it as soon as i get to it.

matke-84 commented 1 day ago

@jurialmunkey Turn off all three "Use fanart.tv..." and you will see that it doesn't work, of course delete cache. I wrote in my issue step by step what is happening just read carefully.

smokyy12 commented 20 hours ago

I just deleted tmdb-helper from addons and userdata and fresh installed it, it seems to work now as it used before. thx again for your fast replies.