Closed xyzfre closed 2 years ago
Watchlist 4.5.31
I can't reproduce using latest github v4.5.31 - works perfectly fine for me. Please test with latest github version.
I didn't try that version yet 4.5.31 ,,when I was on version 4.5.22 I didn't have this issue ,, but when I get a chance I will definitely try the latest version 4.5.31
I can't reproduce using latest github v4.5.31 - works perfectly fine for me. Please test with latest github version.
Just in case if I try the new version and the issue is still there any suggestions that you recommend I should try ,,trying to prepare myself so when I get home I'm hoping it's not on my end everything was working perfectly on version 4.5.22
Just install the latest version 4.5.31 and for some reason still having the same issue it's only happening with my TV shows watchlist being marked as watched but the movies Watchlist it is working properly none of them are checked off as watched
So I reverted back to 4.5.26 and I was correct on that version my TV show watchlist shows up correct but not too sure on what version I started getting the issue I noticed it on 4.5.28
4.5.26
4.5.26
Using K19.3 AuraMod ,,Nvidia shield 2019 would really appreciate any help love using TMDB Helper
@xyzfre I don't have this problem on my skin (titan bingie mod).
I tried revoking Trakt and re- authorizing but no go don't know what else to try I'm not sure why reverting back to 4.5.26 fixes the issue ,, I wonder if it's a skin issue but then again reverting it 4.5.26 fixes it
So I did some more testing by checking different versions ,it looks like on my end the issue started after 4.5.26 because that version is also working properly for my TV show watchlist So the issue started for me on version 4.5.28 and above hope that makes sense
Try deleting trakt cache from expert settings and then restart kodi
Try deleting trakt cache from expert settings and then restart kodi
I just went to settings ,,went to expert under Debug section but all I see is delete cache is that what you're referring to appreciate all this feedback
@xyzfre Yes.
Try deleting trakt cache from expert settings and then restart kodi
I deleted the Trakt cache excited Kodi right after ,and booted it back up and the same issue
sorry for being a pain but confirm on my end right after this commit is when I started having that issue ,,on 4.5.26 it was still working properly,, I wonder if anybody using AuraMod latest version is having the same issue
It's a skin issue due to faulty logic in their watched indicator variables. Specifically this line: `
`
Integer.IsLess
considers None
to be the same as 0
so this condition marks as watched even though this property doesn't exist for these items.
More importantly, it is faulty logic to consider unwatched episodes being 0 to mean the show is watched. There are many reasons an unwatched show might have 0 unwatched episodes for instance it hasn't aired yet so no episodes exist to watch or there's simply no data available.
A more correct variable condition to use would be the following which checks that the watched episode count matches the total episode count and that there is at least 1 episode. `
`
You will need to get the skin author to fix this.
Thank you for your response and for the feedback hopefully it's something that can be addressed because TMDb Helper and AuraMod always have worked well together for me,, and thank you for all your hard work my friend much respect ✊🏼
My apologies for commenting on this old issue again but I was just curious why does this only happen with TMDB H and not other add-ons when using AuraMOD with Trakt it seems it only happens with TV shows not movies ,,on version 4.5.26 and below it works without this issue, that's the version I've been on but would love to update to the newer version
My apologies for commenting on this old issue again but I was just curious why does this only happen with TMDB H and not other add-ons when using AuraMOD with Trakt it seems it only happens with TV shows not movies ,,on version 4.5.26 and below it works without this issue, that's the version I've been on but would love to update to the newer version
Because other add-ons are incorrectly setting a value for unwatched episodes to equal total episodes if they don't have watched episode data.
If you don't know how many episodes have been watched then you don't know how many are unwatched either, so neither value should be set. However, these add-ons are just assuming that "no data" = "none watched" which is not necessarily true.
You can force this type of behaviour by disabling the "Unwatched counts only on in-progress tvshows" setting in TMDbHelper Settings > Accounts
Thank you for your response and your explanation ,and DEFINITELY your work around for this issue ,disabling that option did the trick,feels GREAT!! to be on the latest version of TMDB H I was behind so many updates Thanks again jurialmunkey💯💯💯
Wow!! 👏🏼🙌🏼GREAT job on the current updates seeing a big speed performance since I last updated everything seems much smoother (using Nvidia Shield 2019 Pro with AuraMOD),thank you @jurialmunkey for your AMAZING work with TMDB Helper
Using AuraMod K19.3 Nvidia shield on Android 11 just notice on TV shows watchlist all TV shows show up marked as watched but when you enter the TV show the episodes are correct