search

jurialmunkey / plugin.video.themoviedb.helper

GNU General Public License v3.0
191 stars 94 forks source link

[Feature Request] Hey there, I made some icons for TMDb Helper if you would like to use them. #740

Open Goldenfreddy0703 opened 2 years ago

Goldenfreddy0703 commented 2 years ago

Hey there, i was bored and had nothing to do today so i made you guys a few icons for TMDb Helper and i hope these will help you guys out. If there is an icon that you want me to change, i will change it for you and if you don't want to use these icons, that's totally fine. Hope you have a great day and hope these will help and thank you.

TMDB Genre Icons.zip

Movie Genres

image

TV Show Genres

image

jurialmunkey commented 2 years ago

Hey these are awesome.

What is the source of the icons that you used? I need to make sure that they are open source / free to redistribute before I add them.

Goldenfreddy0703 commented 2 years ago

Oh Hey, I didn't really think about the source of the icon that i used. Alot of these icons are actually from Seren whenever the genre got a redesign and some of the icons such as war & politics, talk, sci-fi & fantasy, kids, and action & adventure are the ones i designed in photoshop, I think they are free to redistribute but let me make sure just incase cause the icons i redesigned were from some google images i found that gave me an idea to redesign them like this.

Goldenfreddy0703 commented 2 years ago

Hey so i just reviewed all the icons that i redesign, and they are free to redistribute as long as its not being used as commercial use.

Goldenfreddy0703 commented 2 years ago

Hey im sorry but i do need to changed the action & adventure, turns out it needed attribution and i wasn't sure. Sorry about that.

Goldenfreddy0703 commented 2 years ago

Ok i updated the zip and fixed action & adventure and this icon im using has no attribution so it should be good

Goldenfreddy0703 commented 2 years ago

Hey there, sense some of these icons i made for TMDb Helper are incompatible with the opensource GPL license, you may want to include this as a separate icon pack "module" and then have a button in settings to install it so that it can be distributed with a different license as well like the Trakt Genres.

jurialmunkey commented 2 years ago

Yes definitely, will make a single pack for all the icons.

Goldenfreddy0703 commented 2 years ago

Yes definitely, will make a single pack for all the icons.

Nice thank you very much and your the best.

Goldenfreddy0703 commented 2 years ago

Hey @jurialmunkey, i gone ahead and made a single pack for all the icons for the genres for tmdb helper.

Goldenfreddy0703 commented 1 year ago

Hey @jurialmunkey , sorry to ping you but i updated this genre pack incase you wanna use this and added a list.png for tmdb genres incase your going to add multi select.

resource.images.tmdbgenreicons.coloured.zip

Hope this helps and again they should also contain trakt genre icons as well.

jurialmunkey commented 1 year ago

Thanks! Awesome! I will work on this feature soon - just been a bit wrapped up in skinning stuff atm.

jurialmunkey commented 8 months ago

@Goldenfreddy0703 - I know this was a long time coming but finally added it! That commit will allow setting a folder for genre icons (and also one for providers).

Since TMDb genre names change depending on locale, I've linked them to their TMDb ID instead. So the files need to be named according to their ID -- e.g. 28.png for Action.

Not sure if adding support for a resource pack is still desirable? Maybe it's simpler to just have a zip that users can extract to a folder and then link the folder -- makes it much easier to customise than trying to unpack a resource and repack it. Thoughts?

Goldenfreddy0703 commented 8 months ago

Oh hey there, I'm surprised you decided to add the Genre icons. Really happy to see that you added them to Tmdb Helper. About the resource, I do find it much easier to have the icons in a separate resource pack but it's totally upto you. Reason why I find it so much easier is cause whenever users update tmdb helper, they don't have to re-download the icon pack. If you also like to, I can try to to make the icon storage smaller without affecting the quality nor size for you so that you can save alot of mb for Tmdb.

Goldenfreddy0703 commented 8 months ago

Hey about making the icon storage smaller without affection the quality. I actually just did that for you in the icons folder of your addon.

image On the left side is your addon unmodified which shows 5.00mb and on the right side is the icons that are modified which shows 1.52mb so i saved you about 3mb of storage incase you would like to use them for your addon.

Hope this helps and here is the zip of those modified icons. Just remember that quality and size was not affected at all.

icons.zip

Goldenfreddy0703 commented 8 months ago

Since TMDb genre names change depending on locale, I've linked them to their TMDb ID instead. So the files need to be named according to their ID -- e.g. 28.png for Action.

Hey im sorry but real quick, where do you find the TMDb ID, im trying to find 28 in your example but do not know where to look. Looked in strings but had no luck. If you can direct me on where to find the TMDb ID, that would be great. image

jurialmunkey commented 8 months ago

Genre IDs are retrieved via API calls https://developer.themoviedb.org/reference/genre-movie-list https://developer.themoviedb.org/reference/genre-tv-list

Here are the current calls

Movies:

{
  "genres": [
    {
      "id": 28,
      "name": "Action"
    },
    {
      "id": 12,
      "name": "Adventure"
    },
    {
      "id": 16,
      "name": "Animation"
    },
    {
      "id": 35,
      "name": "Comedy"
    },
    {
      "id": 80,
      "name": "Crime"
    },
    {
      "id": 99,
      "name": "Documentary"
    },
    {
      "id": 18,
      "name": "Drama"
    },
    {
      "id": 10751,
      "name": "Family"
    },
    {
      "id": 14,
      "name": "Fantasy"
    },
    {
      "id": 36,
      "name": "History"
    },
    {
      "id": 27,
      "name": "Horror"
    },
    {
      "id": 10402,
      "name": "Music"
    },
    {
      "id": 9648,
      "name": "Mystery"
    },
    {
      "id": 10749,
      "name": "Romance"
    },
    {
      "id": 878,
      "name": "Science Fiction"
    },
    {
      "id": 10770,
      "name": "TV Movie"
    },
    {
      "id": 53,
      "name": "Thriller"
    },
    {
      "id": 10752,
      "name": "War"
    },
    {
      "id": 37,
      "name": "Western"
    }
  ]
}

TV

{
  "genres": [
    {
      "id": 10759,
      "name": "Action & Adventure"
    },
    {
      "id": 16,
      "name": "Animation"
    },
    {
      "id": 35,
      "name": "Comedy"
    },
    {
      "id": 80,
      "name": "Crime"
    },
    {
      "id": 99,
      "name": "Documentary"
    },
    {
      "id": 18,
      "name": "Drama"
    },
    {
      "id": 10751,
      "name": "Family"
    },
    {
      "id": 10762,
      "name": "Kids"
    },
    {
      "id": 9648,
      "name": "Mystery"
    },
    {
      "id": 10763,
      "name": "News"
    },
    {
      "id": 10764,
      "name": "Reality"
    },
    {
      "id": 10765,
      "name": "Sci-Fi & Fantasy"
    },
    {
      "id": 10766,
      "name": "Soap"
    },
    {
      "id": 10767,
      "name": "Talk"
    },
    {
      "id": 10768,
      "name": "War & Politics"
    },
    {
      "id": 37,
      "name": "Western"
    }
  ]
}
jurialmunkey commented 8 months ago

Reason why I find it so much easier is cause whenever users update tmdb helper, they don't have to re-download the icon pack.

You shouldn't need to redownload because you can put the icons in any folder - it doesn't need to be inside TMDbHelper's directory or even userdata.

Resource pack definitely makes it easier to stay updated if there's changes to the pack - but I doubt that would happen often.

Goldenfreddy0703 commented 8 months ago

You shouldn't need to redownload because you can put the icons in any folder - it doesn't need to be inside TMDbHelper's directory or even userdata.

Resource pack definitely makes it easier to stay updated if there's changes to the pack - but I doubt that would happen often.

Ahh exactly, thank you for giving me the id's, I didn't know tmdb had genres as id's, that is interesting. Will work on those in 30min.

Thank you

Goldenfreddy0703 commented 8 months ago

Heyyyy @jurialmunkey , today i tested your latest version of tmdb helper and it looks like Genres are showing up on both tmdb and trakt, you did a great job adding this feature and i love it. There is one small bug i found and it has something todo with list view if you look into that.

Here is what i mean: In the TMDB Genres, in the red circle, there are no genre icons in there but they do appear fine on the left. image

In the Trakt Genres, there are genre icons for which do appear on the left and center which is good. image

Btw, sense you made it where you can specify the locations folder for genres. I went ahead and updated my genre pack with a few small changes.

resource.images.tmdbgenreicons.coloured.zip

Goldenfreddy0703 commented 8 months ago

Oh umm, one last thing i forgot to ask is would it be possible to add multiselect for tmdb and trakt genres so we can select multiple genres? I do have the icons for them if you need them and they are both in the genre pack called "list.png" list list

ShaVerZ commented 7 months ago

I can get the trakt genre icons (widget) to display as 'square' but the TMDb genres won't and the viewing options that work are very limited. Most of the viewing options do not display the icons.

Is this an issue because I wanted the genre icons to show as Square and it will display the genre in text also. The only way around it to select 'poster' and expand information to plot.

Goldenfreddy0703 commented 7 months ago

I can get the trakt genre icons (widget) to display as 'square' but the TMDb genres won't and the viewing options that work are very limited. Most of the viewing options do not display the icons.

Is this an issue because I wanted the genre icons to show as Square and it will display the genre in text also. The only way around it to select 'poster' and expand information to plot.

Heyyyy I already reported this issue to @jurialmunkey. Hopefully he will have some time to fix this soon.

https://github.com/jurialmunkey/plugin.video.themoviedb.helper/issues/740#issuecomment-1781980793

ShaVerZ commented 7 months ago

@Goldenfreddy0703 Apologies, I missed that 👍 Great icons mate 👍

samginsberg1 commented 5 months ago

Hey @jurialmunkey I have just made the move from Aeon Nox to AH2 and it's been life changing. I honestly have been spending more time playing around with configuring the skin than watching TV. I wanted to join this discussion as I'm super keen to build out an icon pack for the TMDB providers. I see that you've added the functionality to be able to select a custom folder for these. I'm sick of looking at the existing blurry icons they currently have. How would I got about ensuring that the icons are correctly named? Do they need to be linked to specific ID's like the genres? Look forward to hearing from you!