:bug: Profile pin lock fails due to skin reloading

QuickSwitchLK commented 11 months ago

Skin section

Other

Current Behavior

Hi Jurialmunkey. Thanks again for all your effort you have put into this skin. Because it is so customizable I have gone to multiple profiles, one for the family and the other for me. Family is not locked, but the default profile ( mine ) is locked with a pin. When I log out and I am shown the profile options, if I have been using the unlocked family profile and select mine, sometimes the skin will do a reload before I have hit enter. The result is my profile loads but I didn't have to enter a pin. It has my profile name loaded but no background art from local file on any selection. It is very odd.

Repeat the process of selecting my profile and I am shown a pin and all is OK. It definitely has something to do skin wanting to reload details while the skin is still loading the profile screen.

Switching back to KODI's default skin was all OK but still some odd behavior.

Set default skin. Logged out. switched to other profile, all OK. Set that profile to default skin. Logged out, but Arctic Fuse still does loading of profile screen. Selected main profile. Arctic Fuse was loaded as the skin??? Had to reboot both profiles after selecting default skin for all of Arctic Fuse to disappear.

Expected Behavior

Every time I am shown the profile screen, I am asked for a pin on the locked profile and the profile is not accidentally shown.

Steps To Reproduce

Click profile log out.
Press Left or Right on Keyboard while loading flicking between profiles, or just wait and skin will do a reload.
Default profile will just load with out pin prompt.
Backgound Art and Clearart will not be loaded, landscape and posters are.

Screenshots and Additional Info

No response

Checklist

[X] I have made a separate issue for each bug that I am reporting.
[X] I have searched the issues and this bug has not been reported.
[X] I am using the most recent skin version.
[X] I have confirmed that this bug does not occur in the default skin.

jurialmunkey commented 11 months ago

I can't seem to replicate but can definitely understand how it might happen.

What are your profile settings for the second profile (family) for "media sources" and "media info"? Also, when you made did you choose to copy default or start fresh? Just trying to replicate the setup to see if I can get it to happen on my laptop.

Also, side note: In terms of profiles, would there be any interest in the skin adding its own "pseudo" profile management for home screen widgets? i.e. not real profiles with all the added extras of different addons and media sources, but more of a simple way to have multiple different sets of widgets/menus selectable via a fake login screen.

e.g. to have a "Kids" set of widgets, and then a separate "Adults" set. I could also add a password option --- it wouldn't block Kids from getting into the Adult content entirely but it could certainly be made much more difficult by which shortcuts are made available in the Kids profile.

I'm just thinking that profiles are a probably a bit of overkill a lot of the time when most people really only intend to use them mainly for different home screen widgets for different family members.

QuickSwitchLK commented 11 months ago

The settings of the family profile are "Separate (locked)" for both. To create the second profile I set everything in the main profile, created the new profile with copy default, then copied the correct files and folders of that profile into the second new profile via ssh. (while kodi was killed on libreelec.)

I tried disabling "Hide behind splash screen" in Expert but no change.

I have made a video of it happening and can send it to you privately if you can tell me a way I can msg you direct.

The purpose of my own profile which is locked, is so kids don't have access to file sources and I can stop them from accidentally removing files, or changing settings.

Your addition of profiles might be good for hiding movies and TV series inappropriate for my kids who are getting smart at finding things now.

eesdil commented 7 months ago

I have different profiles, because of in progress and trakt to maintain different history => recommendations...

So unless the pseudo profiles are able to provide this i ll stay with normal profiles.

Actually thats why i am missing logoff and switch profile buttons... but for now i have solved it with adding a category with custom buttons of users. EDIT: Didnt know that you can customize the menu also :) so not missing logoff...

jurialmunkey / skin.arctic.fuse