jurialmunkey / skin.arctic.fuse

Other
160 stars 22 forks source link

💬 Discussion - Widget text sublabels and simple text widget #717

Closed L0bsang closed 4 months ago

L0bsang commented 5 months ago

Skin section

Widgets

Feature description

I would like a return of the text style for widgets, mostly for use with displaying trakt lists in hubs. I imagine there is a plan to return this style at some point, just confirming this is the case.

Why is this feature needed? Please justify and explain.

We used to have a pure text style widget, was recently removed I believe in this commit: https://github.com/jurialmunkey/skin.arctic.fuse/commit/e7e9be6af63c4e5d978fb51ec857e613f6399eac If I understand correctly, that change was done to standardize the widget types (icon is now smaller square for example).

There is a lot of use for this type of widget (if it conforms to the rest of the skin's style and standards).

I know we can use submenus, but when the contents of that submenu's items is a list of items (for example trakt lists) that all have the same icon/image; it is then nice to have a widget that is just the list titles. Then I can use another stacked widget below to show the actual content.

Currently I use icon style (after trying all the others) for these lists of lists because it is the smallest but it is not ideal. I would also accept stacked submenus.

Screenshots and Additional Info

No response

Checklist

jurialmunkey commented 5 months ago

I've got a bit of a different plan for the "Text" style but it works quite well for Trakt Lists:

screenshot00514

There's also a larger "Overview" equivalent style:

screenshot00516

jurialmunkey commented 5 months ago

Just trying to decide whether I prefer the title text outside or inside the box. I think maybe outside is better. Plus makes it a little more consistent with other styles

screenshot00523

screenshot00524

ghost commented 5 months ago

Just trying to decide whether I prefer the title text outside or inside the box. I think maybe outside is better. Plus makes it a little more consistent with other styles

screenshot00523

screenshot00524

I think the inside may be better... gives it a kind of "full package" look, whereas the outside makes the title and genre look isolated and could lead to users asking for a way to switch the genre information off 😅...

The inside look is also more visually appealing, in my opinion

Liltune95 commented 5 months ago

Just trying to decide whether I prefer the title text outside or inside the box. I think maybe outside is better. Plus makes it a little more consistent with other styles

screenshot00523

screenshot00524

Def inside text, Looks more "complete".

L0bsang commented 5 months ago

Very nice!

I'm partial to whichever style shows more title (because descriptions can be empty sometimes).

However they seem to show the same content; in which case I agree that the title text inside does look a bit better, more streamlined for use as a menu item, more of a singular item/button that is visually distinct from other widget styles.

Edit: I do see some value in the text outside style, due to the spacing, and it is more consistent......but text inside is closer to what I would expect from a text widget.

jurialmunkey commented 5 months ago

I think the inside may be better... gives it a kind of "full package" look, whereas the outside makes the title and genre look isolated

Def inside text, Looks more "complete".

On its own, I agree, it looks great and more contained/complete; but it starts to look a bit weird when mixed in with other widgets where the text is outside because the style starts being a bit inconsistent.

could lead to users asking for a way to switch the genre information off

On this point, I was thinking possibly a better approach is a global setting for all views. Then get rid of board because it would handle automatically.

i.e. enable "inside" text makes Landscape turn into Board, and Apps turn into Landscape (but with text inside like Board).

This would deal with the consistency issue a lot better because title text is either internal or external.

The only place I run into difficult is with Square because it doesn't neatly fit the same dimensions. It's always been a bit difficult - definitely the black sheep.

I'm partial to whichever style shows more title (because descriptions can be empty sometimes).

Outside definitely shows more of the title. Inside loses 50 pixels of width in the title to accommodate the edge padding.

L0bsang commented 5 months ago

On this point, I was thinking possibly a better approach is a global setting for all views. Then get rid of board because it would handle automatically.

This change initially didn't sound good to me because on my homepage I mix Board-with-text-labels widgets (for next episodes) and Landscape widgets (for recently aired and stuff like trakt calendar) so there is clear differentiation between them.

However after some thought I guess I could instead use Landscape instead of board and Apps instead of landscape. 🤔 So probably ok, as long as the text is quite legible when inside, and it looks good.

jurialmunkey commented 5 months ago

So probably ok, as long as the text is quite legible when inside, and it looks good.

You can see what this looks like currently for Board with the option: Skin Settings > Viewtypes > Show text labels on board widgets

The "Apps -> Landscape" switch would be the same as that but at the smaller size.

xyzfre commented 5 months ago

@jurialmunkey I noticed with this new feature A lot of things have labels under for example, in this picture every icon has the word folder image

ghost commented 5 months ago

@jurialmunkey I noticed with this new feature A lot of things have labels under for example, in this picture every icon has the word folder image

Yeah, and widgets and some files have 0.00 B

L0bsang commented 5 months ago

@xyzfre Is that the square style? Haven't been able to try the new version of the skin yet but I definitely agree that the repeated 'Folder' doesn't belong. Even in the mockup, 'Trending Lists" is repeated on every item but definitely not needed there, title label only is quite sufficient for non-content widgets.

JFG1000 commented 5 months ago

@jurialmunkey I've also noticed the square widget sizes for addons are huge now with the board mode enabled, is there anyway they can be reverted back to Squares original size?

Chalklands commented 5 months ago

@jurialmunkey I noticed with this new feature A lot of things have labels under for example, in this picture every icon has the word folder image

Yeah, and widgets and some files have 0.00 B

Yes, I agree with the 0,00 B text.

xyzfre commented 5 months ago

Love the new large board mode but if there's a way to have an option for plugins categories back to the original smaller square size.

JFG1000 commented 5 months ago

Yes please jurial smaller plugin widgets would be great they are massive now

jurialmunkey commented 5 months ago

Smaller sizes require text underneath to fill the space. Either on or off. Not mix and match

jurialmunkey commented 5 months ago

Completely defeats the purpose of a setting designed to fill the space to then have views which do not do so. Turn off board mode if you want smaller sizes

jurialmunkey commented 5 months ago

All labels have been standardised. Suggest a good sublabel to use if you do not think folder is appropriate.

ghost commented 5 months ago

All labels have been standardised. Suggest a good sublabel to use if you do not think folder is appropriate.

Is it possible to have a skin wide blank text as the sub label... it'll act the same way as a normal text would 🤔... just a suggestion: I don't really know the logistics

L0bsang commented 5 months ago

Happy to help sort out the appropriate sublabels as I definitely agree with others that it does apply some redundant information for non-content widgets (that honestly I think I could possibly live with, but will be trying it out myself shortly).

What are our options?

I lack skinning knowledge so these are some rough ideas.

L0bsang commented 5 months ago

I've had a chance to try the changes and the new text widget works ok in certain cases but has repeated text when using it for a menu or set of folders with no plot information.

To illustrate, an example of how the various styles look when using a menu as a widget:

New Text style image

New Overview style image

Icons image

Apps image

Fully repeated information for the text/overview styles. Best display in terms of text shown and sizing seems to be text style without the redundant labels. Currently I am using apps/icon for these menu widgets and both seem better than text at the moment. Apps shows a bit more text than icon, but then uses landscape art, which some menus do not have.

But icon and apps styles have their own drawbacks. Here the 0.00B looks out of place next to my smart playlist items (some are playmedia and others are browse): image Program addons have this 0.00B sublabel as well.

On the plus side, the trakt lists from TMDBHelper do look quite good with the new text style! image

To summarise: I can learn to live with the new text style (decent for trakt lists) but it doesn't seem ideal for menus.

xyzfre commented 5 months ago

@L0bsang thank you for posting these views already giving me some ideas 😁,I never tried using submenu widgets, but they look good, I've used them when I was using AH2.

xyzfre commented 5 months ago

In your last pic with the trending popular list ,for it to show the text inside do I need to have the new setting the large board enabled can't remember exactly the name of the setting right now my apologies.

jurialmunkey commented 5 months ago

In your last pic with the trending popular list ,for it to show the text inside do I need to have the new setting the large board enabled can't remember exactly the name of the setting right now my apologies.

Yes. That is what the setting does -- board widgets remove external widget text, then their bounding box is expanded to fill the space, and optionally widget text can then be placed inside the box.

jurialmunkey commented 5 months ago

@L0bsang

Can sublabel visibility be content type dependent i.e. visible for shows, movies and episodes but not for folders and files?

The big part of this push is to standardise the labels across all types, so no to changing visibility. However, which label is shown can be changed depending on content type -- e.g. this already happens with tvshows to show tvshow title instead of genre; or for live tv to show channel name.

For example instead of 0.00B for files

I've removed size. Not even sure why I had that in the first place. There must be some place it is useful but I can't really remember why at the moment -- if I do remember I'll add it back with a more specific rule because it definitely shouldn't display constantly.

then for folders in an addon the previous menu/folder is shown instead of type.

It does sort of do this already but is dependent on the plugin setting the ListItem.Property(widget) value. For e.g. in TMDbHelper if you go in TVDB > Awards you can see the label update. But this also feels a little redundant because if this is set, the label is already shown in the view line above the widget anyway.

could have a bit of their path or something like that,

Possible but I tend to shy away from showing "technical" information like that as it is a bit meaningless to the layperson. It's meaningful for me but not necessarily someone else in my house wanting to watch a movie.

It starts to feel like it is exposing the machinery too much if you get what I mean.

I imagine having the option to blank out labels/sublabels on a per-widget basis would also be a lot of work and not the right solution. Potentially if sublabel is editable on a per-widget basis then users can put a blank text label where necessary as some have done for spotlight labels.

Less about the work and more that it isn't the path I want to head down. It's the opposite direction from standardisation of skin elements and makes the skin look inconsistent and unpolished.

I don't want to be adding in short circuits for users to try to "fix" the skin to their liking. I'm all for customisation but this isn't customisation -- it is trying to bend the skin design to be something else.

L0bsang commented 4 months ago

Fully agreed, thanks for the explanation of your direction. I especially agree about the path not being a good option for the label due to exposing the inner workings.

Looking forward to seeing how the adjustments will look. The most egregious sub-label indeed was the size, (which can be useful but not for the homepage widgets) so removing that is great.