jurialmunkey / skin.arctic.fuse

Other
160 stars 22 forks source link

💬 Discussion - Board mode label options #720

Closed vella9 closed 4 months ago

vella9 commented 5 months ago

Skin section

Widgets

Current Behavior

First of all I really like the new board mode. Nicely done @jurialmunkey . However I have one issue. I have a mixture of board and landscape widgets. With board mode enabled and landscape labels enabled, I am still getting labels on the board widgets.

Expected Behavior

board mode should not display labels in board widgets with landscape labels enabled

Steps To Reproduce

  1. enable board mode
  2. enable landscape labels only
  3. labels are still displayed in board widgets.

Screenshots and Additional Info

No response

Checklist

jurialmunkey commented 5 months ago

Landscape becomes board with the toggle, so they both end up following the "landscape" rule (which is what board is).

I guess it makes sense to have both so some can be with or without labels. Though I was thinking maybe the setting could be type specfic instead - eg can select which content types labels show for eg episodes only etc.

So don't need to worry about which widget type is set and it just automatically follows the setting.

jurialmunkey commented 5 months ago

Is that the type of issue being faced - ie you want episodes to have labels but tvshows etc not to - or is it more specific than that? Just trying to understand better to go for best solution.

vella9 commented 5 months ago

I currently have all my widgets set to board with the exception of 'continue watching episodes' and 'up next episodes' where these are set to landscape because I like to have the show name, episode number and episode name at a glance.

Aesthetically, I prefer to have the board widgets without labels since I noticed that most of the board widgets have overlapping text similar to the below and it is not visually appealing.

Capture

I really like the new landscape with the labels now part of the board itself and it fits perfectly with 'continue watching episodes' and 'up next episodes' since the thumbnail of these widgets doesn't have any text. It is beautiful, as you can see below.

Capture2

Let me know if you require anything else and thank you for everything that you do for us @jurialmunkey .

L0bsang commented 5 months ago

With the current options in v06.16 you could use text inside and then landscape with labels will turn into board for your episodes.

Then you can use ordinary board (will not show text if text inside is enabled) for your content widgets.

jurialmunkey commented 5 months ago

@L0bsang there's actually an override when the setting is enabled which forces board widgets to be the default widget (generally landscape but could be something else if submenu widgets are used).

So one way to solve it is to turn off that override and do what you're suggesting.

What I'm wondering though is if it would be better to have the setting allow selecting content types - that way it would also apply in the library/plugin media views - - eg I could see some people also wanting episodes in library to have labels but not tvshows/movies.

vella9 commented 5 months ago

What I'm wondering though is if it would be better to have the setting allow selecting content types - that way it would also apply in the library/plugin media views - - eg I could see some people also wanting episodes in library to have labels but not tvshows/movies.

I think that this would be a good option since we will get a selection to choose where we want the board style enclosed widgets to be applied.

L0bsang commented 5 months ago

Ah I see, I noticed my episode widgets which used board before 0.6.16 just no longer had text on them whether using inside or outside, so I imagined there were two types of board.

I've tried the the current implementation and agree it could be improved. Mostly because text inside is a bit cramped on any style that isn't board-sized, it seems better to have it outside for those smaller styles. However I guess it does solve people's issue with text on landscape because one could turn text inside on, then use app style which expands to landscape and then turn text off on apps style.... for me it seems convoluted, all just to remove text from landscape sized widgets.

Content type selection might be the answer for this, @jurialmunkey do you mean content type will control the inside/outside of text or will it control the display of labels on the inside?

jurialmunkey commented 5 months ago

I mean per style the content type would decide if labels are on or off.

Eg could set board to have labels only for videos and episodes, but not movies, tvshows or artists etc.

jurialmunkey commented 4 months ago

I've tried the the current implementation and agree it could be improved. Mostly because text inside is a bit cramped on any style that isn't board-sized, it seems better to have it outside for those smaller styles. However I guess it does solve people's issue with text on landscape because one could turn text inside on, then use app style which expands to landscape and then turn text off on apps style.... for me it seems convoluted, all just to remove text from landscape sized widgets.

Yeah I think I jumped the gun with the "board mode" a bit.

I thought it would be a neat and tidy solution to be consistent across the skin, but now that I've had a bit of time today to work on things a bit I'm finding it is really cornering me into some difficult spots to get out of. There's some spots where it really just doesn't work (e.g. square) and some other parts like you're saying where it gets a bit cramped -- it also makes it so that I'm essentially managing two skins: one with board mode on and one with board mode off, which is a headache!

I think I'm going to have to walk it back a bit a try a different approach before it gets too convoluted.

L0bsang commented 4 months ago

it also makes it so that I'm essentially managing two skins: one with board mode on and one with board mode off, which is a headache!

I think I'm going to have to walk it back a bit a try a different approach before it gets too convoluted.

We definitely don't want it to become a headache! A different approach is definitely welcome.

jurialmunkey commented 4 months ago

Next version I think probably deals with this better.

Instead of Board mode there are now small (S) versions of: Board, Landscape, Square, and Overview

I've removed the Apps/Text/Icon names to reduce ambiguity.

So...

Board = Card sized landscape without labels Board (S) = Standard sized landscape without labels

Landscape / Square / Overview -- as before

Landscape (S) = Previously called "Apps" (i.e. a smaller sized landscape) Overview (S) = Previously called "Text" (i.e. a smaller sized overview) Square (S) = Previously called "Icon" (i.e. a smaller sized square)

The smaller square size also has a simplified smaller label owing to its smaller size. Should mean it also works a bit better as a replacement for the old old version of text.

I'm also trialing centring the labels which I feel softens them a bit whilst also making them feel a bit more connected to the item.

L0bsang commented 4 months ago

The smaller square size also has a simplified smaller label owing to its smaller size. Should mean it also works a bit better as a replacement for the old old version of text.

I did notice that! I'm using small square (used to be icon) for my stacked menus and playlists at the moment (overview styles for menus have "no information available" text on the widget) and it works quite well!

Is there any board/card sized style that also has labels? It's alright if there isn't I can just use landscape if I want labels and deal with the smaller size. Speaking of card, it seems to be using the fanart/background-art when it expands, I was wondering if it is possible for it to use episode thumbnail either by default or as a selectable option? That may be a neat option for episode widgets.

Thanks for the update and quick fixes, had some overlapping labels on 0.6.17/18 but 0.6.19 is fine. I will test some more later. Wondering what features were added, I see a circle view style. 🤔

vella9 commented 4 months ago

Is there any board/card sized style that also has labels?

same taught here as well, a 'per widget' option/toggle under style in the 'widget customization options' to display text inside the board/card styles would be awesome. 🙏

I'm also trialing centring the labels which I feel softens them a bit whilst also making them feel a bit more connected to the item.

I still prefer the old left indent, but just a personal preference.

Thanks as always @jurialmunkey

jurialmunkey commented 4 months ago

No to per widget options. Needs to be set as the style.

JFG1000 commented 4 months ago

Next version I think probably deals with this better.

Instead of Board mode there are now small (S) versions of: Board, Landscape, Square, and Overview

I've removed the Apps/Text/Icon names to reduce ambiguity.

So...

Board = Card sized landscape without labels Board (S) = Standard sized landscape without labels

Landscape / Square / Overview -- as before

Landscape (S) = Previously called "Apps" (i.e. a smaller sized landscape) Overview (S) = Previously called "Text" (i.e. a smaller sized overview) Square (S) = Previously called "Icon" (i.e. a smaller sized square)

The smaller square size also has a simplified smaller label owing to its smaller size. Should mean it also works a bit better as a replacement for the old old version of text.

I'm also trialing centring the labels which I feel softens them a bit whilst also making them feel a bit more connected to the item.

Has this been added in version .19 jurial as I cannot see it unfortunately

L0bsang commented 4 months ago

I just had an idea, inspired by flipping back to Horizon 2. 😅 Large landscape [Landscape (L)] as an additional widget style. Then everyone can be happy, two sizes of board styles with no text can be used and three sizes of landscape styles with text can also be used. Labels outside for medium and small landscape, label inside for the large landscape. Also standardizes the idea that board has no labels and landscape does.

I imagine you already have this in mind. The only drawback I can think of is that may be too many widget styles, but apart from that I can see only positives with this set of options.

@JFG1000 , yes I have additional options for widget styles showing on .19

JFG1000 commented 4 months ago

I just had an idea, inspired by flipping back to Horizon 2. 😅 Large landscape [Landscape (L)] as an additional widget style. Then everyone can be happy, two sizes of board styles with no text can be used and three sizes of landscape styles with text can also be used. Labels outside for medium and small landscape, label inside for the large landscape. Also standardizes the idea that board has no labels and landscape does.

I imagine you already have this in mind. The only drawback I can think of is that may be too many widget styles, but apart from that I can see only positives with this set of options.

@vella9, yes I have additional options for widget styles showing on .19

This would be awesome, i cannot see the new widget styles on 19 I'm using classic mode. I. Don't have the small board widget or anything

Blackysbd commented 4 months ago

The smaller square size also has a simplified smaller label owing to its smaller size. Should mean it also works a bit better as a replacement for the old old version of text.

I did notice that! I'm using small square (used to be icon) for my stacked menus and playlists at the moment (overview styles for menus have "no information available" text on the widget) and it works quite well!

Is there any board/card sized style that also has labels? It's alright if there isn't I can just use landscape if I want labels and deal with the smaller size. Speaking of card, it seems to be using the fanart/background-art when it expands, I was wondering if it is possible for it to use episode thumbnail either by default or as a selectable option? That may be a neat option for episode widgets.

Thanks for the update and quick fixes, had some overlapping labels on 0.6.17/18 but 0.6.19 is fine. I will test some more later. Wondering what features were added, I see a circle view style. 🤔

I just had an idea, inspired by flipping back to Horizon 2. 😅 Large landscape [Landscape (L)] as an additional widget style. Then everyone can be happy, two sizes of board styles with no text can be used and three sizes of landscape styles with text can also be used. Labels outside for medium and small landscape, label inside for the large landscape. Also standardizes the idea that board has no labels and landscape does.

I imagine you already have this in mind. The only drawback I can think of is that may be too many widget styles, but apart from that I can see only positives with this set of options.

@JFG1000 , yes I have additional options for widget styles showing on .19

I think this is a great idea.

L0bsang commented 4 months ago

... i cannot see the new widget styles on 19 I'm using classic mode. I. Don't have the small board widget or anything

@JFG1000 After the skin updated I had a bug on classic mode where no widgets were appearing. I did a rebuild in widget customization but that didn't fix it, however when I changed menu visibility/minimise to topbar, my widgets started appearing on classic mode, and remained when I switched back to sidebar.

I hadn't checked the new styles beforehand, but they were certainly there after I had resolved this other issue.

JFG1000 commented 4 months ago

Many thanks are they labeled as something else now? Could you explain to me how to change the visibility thing so i can try my end, thankyou

Sent from Outlook for Androidhttps://aka.ms/AAb9ysg


From: L0bsang @.> Sent: Monday, April 15, 2024 6:55:06 PM To: jurialmunkey/skin.arctic.fuse @.> Cc: JFG1000 @.>; Mention @.> Subject: Re: [jurialmunkey/skin.arctic.fuse] 💬 Discussion - Board mode label options (Issue #720)

... i cannot see the new widget styles on 19 I'm using classic mode. I. Don't have the small board widget or anything

@JFG1000https://github.com/JFG1000 After the skin updated I had a bug on classic mode where no widgets were appearing. I did a rebuild in widget customization but that didn't fix it, however when I changed menu visibility/minimise to topbar, my widgets started appearing on classic mode, and remained when I switched back to sidebar.

I hadn't checked the new styles beforehand, but they were certainly there after I had resolved this other issue.

— Reply to this email directly, view it on GitHubhttps://github.com/jurialmunkey/skin.arctic.fuse/issues/720#issuecomment-2057496059, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ASKYKPDQ5ASKUIDAV3LRLKLY5QH7VAVCNFSM6AAAAABGCSOOBSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANJXGQ4TMMBVHE. You are receiving this because you were mentioned.Message ID: @.***>

jurialmunkey commented 4 months ago

@JFG1000 - Do you have footer enabled on Home/Hub widgets? Small sizes are not compatible with the footer.

jurialmunkey commented 4 months ago

I imagine you already have this in mind. The only drawback I can think of is that may be too many widget styles, but apart from that I can see only positives with this set of options.

The drawback is where does it end? Why not also on smaller landscape? Posters? Square? Overview? Then we come full circle back to the "board mode".

The main issue is that I find the style inconsistent. I'm okay with small square/circle having a simplified smaller text label because the style is still the same (centered, external) and we see that type of scaling across most applications where zooming out makes labels smaller and more simplified.

The issue with text inside is that it introduces a new style that differs from how the rest of the skin handles text labels. I'm not saying it looks bad - I definitely understand the appeal - but the problem is it starts becoming a bit hodge podge.

Sure, people could set up their home screens with a consistent style but they can't get the same style in the library unless I also add it there. And from a technical standpoint, that means wall needs to be removed because of a skin engine limitation causing display issues with missing elements once the skin reaches some hidden limit on the number of allowed skin variables.

JFG1000 commented 4 months ago

@JFG1000 - Do you have footer enabled on Home/Hub widgets? Small sizes are not compatible with the footer.

I'm not sure, could you explain how i can check please

L0bsang commented 4 months ago

The drawback is where does it end? Why not also on smaller landscape? Posters? Square? Overview? Then we come full circle back to the "board mode".

Fair enough. I think text inside fits well on board but is cramped on the smaller styles, so I think it can just end here. But I see what you are saying, based on all the different requests you get.

The main issue is that I find the style inconsistent. I'm okay with small square/circle having a simplified smaller text label because the style is still the same (centered, external) and we see that type of scaling across most applications where zooming out makes labels smaller and more simplified. The issue with text inside is that it introduces a new style that differs from how the rest of the skin handles text labels. I'm not saying it looks bad - I definitely understand the appeal - but the problem is it starts becoming a bit hodge podge.

I see, again can't disagree with that! We've had text inside before on this skin and previous skins, I think everyone likes it as a style for episodes. But it's your call about the consistency, we appreciate your work on this skin and your satisfaction with it takes precedence over all our little personal preferences. Personally I can learn to live with it.

Sure, people could set up their home screens with a consistent style but they can't get the same style in the library unless I also add it there. And from a technical standpoint, that means wall needs to be removed because of a skin engine limitation causing display issues with missing elements once the skin reaches some hidden limit on the number of allowed skin variables.

That's some good insight on the skin engine limitation, thanks for explaining! I think it is ok if styles slightly differ from homescreen/hub to library due to their varying purposes, and don't see a problem either with having that style also in the library. Footers instead of widget peek is already a noticeable homescreen to library inconsistency if one sets it up that way, but for a good reason/purpose. But I definitely concede to your greater expertise in this issue of consistency. In my opinon wall is a rather underwhelming feature because unlike AH2 you don't actually interact with it at all, a portion of it is consistently covered by the view window at all times and it apparently negatively impacts performance. I for one wouldn't be mad if it was removed, but I may be in the minority here.

JFG1000 commented 4 months ago

I definitely agree with @L0bsang text inside the widget fits perfectly, and loved it with AH2 with larger sized widgets, board being this case for fuse, it was ideal for next episodes etc, but we appreciate everything you do for us so if it's it's completely up to you jurial

L0bsang commented 4 months ago

@JFG1000 - Do you have footer enabled on Home/Hub widgets? Small sizes are not compatible with the footer.

I'm not sure, could you explain how i can check please

@JFG1000 Footer enable/disable for Home widgets can be found here: image

Selected setting will not show a footer on home widgets.

New widget styles: image

Hope that helps!

JFG1000 commented 4 months ago

@L0bsang thanks mate appreciate it, sorted just hoping we can get board with text inside the widget back if jurial approves 🤞🏻

vella9 commented 4 months ago

+1 for text inside the board widget if this is approved. 🤞🏻🙏

vella9 commented 4 months ago

Thank you for the Board (T) @jurialmunkey!

vella9 commented 4 months ago

Just 1 minor thing, about the alignment of the text inside Board (T).

A thing I noticed is that since the text inside the Board (T) is now centered, aesthetically it is not in a way conformant with the rest of the skin as per below image. As one can notice, from the very top, the hub name (TV Shows), time and date, infoline, plot, widget title are all aligned perfectly and all of a sudden the episode name and show name looks out of place.

On the other hand though, it makes perfect sense since it is in line properly with the indicator (season premiere)

image

This is something that I noticed and wanted to mention. That's all. Thank you as always for your impressive work!

JFG1000 commented 4 months ago

@vella9 if you ask me mate it's fine as it is, and honestly would prefer it left as it is as the alignment seems fine, we should just appreciate that Jurial has added it back as it was recently removed 👍🏻

vella9 commented 4 months ago

@vella9 if you ask me mate it's fine as it is, and honestly would prefer it left as it is as the alignment seems fine, we should just appreciate that Jurial has added it back as it was recently removed 👍🏻

as I said, this is something I noticed and just wanted to mention since this is a discussion. I always appreciate and thank jurial for his work.

L0bsang commented 4 months ago

Yes, definitely a good contribution to the discussion, @vella9 , so we can come to a consensus on the best approach by considering all the options.

Center-alignment is currently more consistent with the other widgets and I think that is the idea/plan. Looks ok to me, especially because the other elements you mentioned definitely must be left-aligned and have a clear separation from the widget items. Treating the widget items as a separate element means to me that it isn't aesthetically non-conformant, instead it conforms nicely to the rest of content display.

Edit: However if you are trying to say left alignment is better than center-alignment for all the widgets, that is a whole different discussion and you may have a good point. I am undecided myself on which alignment looks better.

Thanks again for hearing us out and adding it in @jurialmunkey! 🥳

JFG1000 commented 4 months ago

@vella9 if you ask me mate it's fine as it is, and honestly would prefer it left as it is as the alignment seems fine, we should just appreciate that Jurial has added it back as it was recently removed 👍🏻

as I said, this is something I noticed and just wanted to mention since this is a discussion. I always appreciate and thank jurial for his work.

That's cool mate I wasn't intentionally being negative

JFG1000 commented 4 months ago

@JFG1000 - Do you have footer enabled on Home/Hub widgets? Small sizes are not compatible with the footer.

I'm not sure, could you explain how i can check please

@JFG1000 Footer enable/disable for Home widgets can be found here: image

Selected setting will not show a footer on home widgets.

New widget styles: image

Hope that helps!

@jurialmunkey just out of curiosity how come the new widgets are not available with footer enabled? My guess is it does not fit correctly? I used to use footer so I'm just wondering is all

ghost commented 4 months ago

@JFG1000 - Do you have footer enabled on Home/Hub widgets? Small sizes are not compatible with the footer.

I'm not sure, could you explain how i can check please

@JFG1000 Footer enable/disable for Home widgets can be found here: image

Selected setting will not show a footer on home widgets.

New widget styles: image

Hope that helps!

@jurialmunkey just out of curiosity how come the new widgets are not available with footer enabled? My guess is it does not fit correctly? I used to use footer so I'm just wondering is all

It affects the fade transition... stated by Jurial a while back