jurialmunkey / skin.arctic.fuse

Other
164 stars 23 forks source link

:bug: classic mode navigation issues #826

Closed vella9 closed 5 months ago

vella9 commented 5 months ago

Skin section

Widgets

Current Behavior

content>back parent is broken with latest update 0.6.30. pressing back from any widget always takes you to the first side menu item and not respective side menu item.

content>end is bumping and not wrapping anymore. was this navigation setting removed on latest version as I cannot find it anymore? even from first item of any widget, when pressing left, focus in moving to first side menu item and not wrapping to the end of the widget.

I have the following navigation settings configured:

image

Expected Behavior

content>back parent should take you respective side menu item as before.

option for content>end to wrap from first to last item of widget row.

Steps To Reproduce

press back from any widget and focus will go to first side menu item.

press left from first widget and focus will go to first side menu item and not wrapping to last item of widget.

Screenshots and Additional Info

No response

Checklist

jurialmunkey commented 5 months ago

Disable "Menu > Left = Options" and it will wrap.

jurialmunkey commented 5 months ago

content>back parent is broken with latest update 0.6.30. pressing back from any widget always takes you to the first side menu item and not respective side menu item.

Not broken, it is intentional.

Classic mode now contains all widgets in a single grouplist.

Pressing back to go to the parent item takes you to the top of the grouplist. That is the first widget.

If you want widgets to be broken into separate groups, then disable the option to move between groups.

vella9 commented 5 months ago

Disable "Menu > Left = Options" and it will wrap.

focus is still going to side menu before wrapping. not how it was before (from first to last item of widget row)

If you want widgets to be broken into separate groups, then disable the option to move between groups.

I had this option enabled due to #673. Will test this again and let you know.

jurialmunkey commented 5 months ago

focus is still going to side menu before wrapping. not how it was before (from first to last item of widget row)

I needed to simplify these options.

If side menu is expanded, the left/right movement loops through the menu (and if menu set to open on left it stops at ends). If side menu is minimised, the content wraps (and up goes to the menu instead).

So if you want content to wrap, then minimise the menu.

I had this option enabled due to https://github.com/jurialmunkey/skin.arctic.fuse/issues/673. Will test this again and let you know.

I think that issue should be mostly fixed now (hopefully). Next update will improve it further.

vella9 commented 5 months ago

focus is still going to side menu before wrapping. not how it was before (from first to last item of widget row)

I needed to simplify these options.

If side menu is expanded, the left/right movement loops through the menu (and if menu set to open on left it stops at ends). If side menu is minimised, the content wraps (and up goes to the menu instead).

So if you want content to wrap, then minimise the menu.

On a personal side of things, I prefer the menu expanded tbh, I think that this is the best view for classic mode (couldn't set it to open on left though, not sure how this is done).

Another personal preference is the way navigation was handled before these changes. I think that it looked and felt better/smoother. On the latest updates, to have the same behavior as before, I had to sacrifice 'the move between widgets' option and although it contains the sections much better, widget continuation between different sections is lost.

Then again, these are just my personal preferences and I don't want to intrude, as I do not know the what plans you have for this amazing skin. I appreciate your time and effort to accommodate us on a daily basis. Thank you.

I had this option enabled due to #673. Will test this again and let you know.

I think that issue should be mostly fixed now (hopefully). Next update will improve it further.

I tested this a bit yesterday and it looks like it is fixed now, thank you for this, the only thing that I wanted to mention is that upon returning to the main screen, any button press will take you to the first side menu item. Other than that, the main issue seems fixed. Thanks once again.

jurialmunkey commented 5 months ago

On a personal side of things, I prefer the menu expanded tbh, I think that this is the best view for classic mode

That's the same as what I use myself. But I find wrap to be confusing compared against looping.

Can you explain a bit more how you use it with wrap enabled? Don't you find it confusing that pressing left at the start of the list doesn't go left to the menu and instead wraps around?

Or is this with touch mode enabled to disable the screen peek? That's the only way I can wrap (excuse the pun) my head around it making any sort of sense to prefer wrap over loop with menu expanded.

I'm not opposed to wrap entirely, just want to remove some of the more micro type navigation settings to ensure there is a reliable pattern of navigation -- it gets a bit much trying to manage every possible permutation in every possible configuration and all that I end up doing is fixing one problem to cause another in an endless game of whack-a-mole.

(couldn't set it to open on left though, not sure how this is done).

No, no, this is a misunderstanding. The setting toggles whether on left again from the menu will then open the options (power) dialog (or view filter in library, or discover filter in discover etc.)

That's why it makes it also bump on the right -- since you can't continue left to loop around, the loop is also disabled on the right.

Another personal preference is the way navigation was handled before these changes. I think that it looked and felt better/smoother.

It's less about preference and more about working within the technical limitations of the skin engine. Either the skin is a buggy mess where you can get trapped on the side menu and need to restart Kodi to regain control, or these sacrifices are made.

vella9 commented 5 months ago

Can you explain a bit more how you use it with wrap enabled?

I used to have Content>Ends wrap so that each widget will wrap itself. If focus is set on one of the items in a widget row, I would know that left/right presses will only be in that widget row and not having focus to shift back to the side menu. I like the way it navigates from first to last item without going to the side menu.

Don't you find it confusing that pressing left at the start of the list doesn't go left to the menu and instead wraps around?

No, not really, I find it more contained to have any arrow key button press (left, right, up, down) to always be within the widget rows, and back button to go to parent, in this case side menu item since I have Content>Back parent, if I want to go to the side menu item, I just press back. With 'move between widget groups' disabled, I find it attractive to use arrows for widget rows and back to go to side menu.

Or is this with touch mode enabled to disable the screen peek?

No, this is disabled in my case.

I'm not opposed to wrap entirely, just want to remove some of the more micro type navigation settings to ensure there is a reliable pattern of navigation -- it gets a bit much trying to manage every possible permutation in every possible configuration and all that I end up doing is fixing one problem to cause another in an endless game of whack-a-mole.

I can only imagine how complex it can get on such different scenarios/setups.

No, no, this is a misunderstanding. The setting toggles whether on left again from the menu will then open the options (power) dialog (or view filter in library, or discover filter in discover etc.)

Oh ok, got it now.

Thank you as always jurial for looking into such issues.

vella9 commented 5 months ago

@jurialmunkey would it make sense adding a 'Menu>Left' bump or null (does not loop) option? Not sure if the bump effect itself fits well enough.

Just thinking out loud here, at least this way, it won't loop from widget first item to side menu and to widget last item upon presses. It would bump/null on menu left press. as for widget last item, it would need to bump onright as well.

Just a thought is all.

jurialmunkey commented 5 months ago

Managed to figure out a way for back to go to current group icon even if move between enabled https://github.com/jurialmunkey/skin.arctic.fuse/commit/ba3ef1432ae55ca4cdb97798eca8f60c8c2e8759

Just thinking out loud here, at least this way, it won't loop from widget first item to side menu and to widget last item upon presses. It would bump/null on menu left press. as for widget last item, it would need to bump onright as well.

To me that sounds worse.

IMHO bump on left would be the least expected behaviour. I'd expect it to either to wrap or go to the side.

A good middle ground might be to have onback=menu automatically wrap rows always (i.e. if onback=menu then widgets always behave as if the menu were minimised even if it isn't).

I think wrapping lists is the only real reason to enable onback=menu anyway, so may as well bundle it.

That still cuts down on micro options. And more importantly, it prevents the user from locking themselves out from the menu -- which is good for me because it means less people complaining at me about their bad choices of settings making the skin not make sense.

vella9 commented 5 months ago

Managed to figure out a way for back to go to current group icon even if move between enabled ba3ef14

Awesome jurial, thank you. However, when setting onback=menu with move between enabled, it is not respecting the navigation as intended. It is defaulting to the last side menu item that had focus.

A good middle ground might be to have onback=menu automatically wrap rows always (i.e. if onback=menu then widgets always behave as if the menu were minimised even if it isn't).

I think wrapping lists is the only real reason to enable onback=menu anyway, so may as well bundle it.

Great addition, thank you for this jurial 🙏 I owe you a coffee.

because it means less people complaining at me about their bad choices of settings making the skin not make sense.

I'm sorry for the hassle that I might have caused. Definitely not my intention, I try to be as nonintrusive as possible, but still report any issues/bugs that I find for the benefit of this great skin. Thank you as always @jurialmunkey!

jurialmunkey commented 5 months ago

No no hassle! Not directed at you. I have no problem people reporting bugs or making requests (as long as it is somewhat thought out and they aren't rude about it).

I should be able to adjust menu onback to go to correct position - just an oversight.

vella9 commented 5 months ago

I should be able to adjust menu onback to go to correct position - just an oversight

great, thank you @jurialmunkey!

vella9 commented 5 months ago

when setting onback=menu with move between enabled, it is not respecting the navigation as intended.

I also noticed that this is occurring when setting onback=parent with move between enabled. When you press left (not back this time) to go to side menu, it is not respecting the navigation as intended.

xyzfre commented 5 months ago

@vella9 where did you find the setting move between widgets. I tried looking for it, but I could not find it. I use complex mode.

vella9 commented 5 months ago

@xyzfre if I remember correctly this was removed for complex mode. Not sure though cause I use classic mode. For classic mode it is under Navigation.