jurialmunkey / skin.arctic.fuse

Other
143 stars 21 forks source link

:bug: Side menu labels show 'Search & Options' even when the option is disabled #914

Closed OfficerKD637 closed 1 month ago

OfficerKD637 commented 1 month ago

Skin section

Widgets

Current Behavior

Hey Jurial!

Hope you've been doing well! The last few skin updates have been gamechangers! I think we are finally soooo close to a 'beta' release. Just need to find a way to map the 'Discover' hub [ActivateWindow (1105)] to the onup action in Home haha

Here's the bug:

If the 'Sidemenu > Show labels when minimized' is enabled but the 'Search & Options' is disabled, those icons still show up.

Is there an easy fix to remove those two items while still have the labels enabled?

Expected Behavior

Hide the 'Search & Options' icons from the sidemenu when 'Show labels when minimized' is enabled.

Steps To Reproduce

  1. Disable 'Search & Options'
  2. Enable 'Show labels when minimized'

The icons still show up

Screenshots and Additional Info

No response

Checklist

OfficerKD637 commented 1 month ago

Sorry to comment on a closed issue but I just tested out this commit and I found a small navigation bug.

When the sidemenu is set to minimize always (so clicking left will wrap), 'Search & Options' is disabled and the expanded side menu is brought out (the new profile on top looks very cool!), there's no way to go to the options panel anymore. Clicking left doesn't do anything and pressing back just slides in/out the expanded side menu on the home screen.

This is with Back set to Parent.

Maybe we get rid of the Kodi version at the bottom and keep the 'Options'? Let me know what you think.