jurialmunkey / skin.arctic.fuse

Other
164 stars 23 forks source link

Shadow on the image when the video player OSD appears. #920

Closed Bindou01 closed 4 months ago

Bindou01 commented 4 months ago

Skin section

Video OSD

Current Behavior

Hi Jurial, The Clear Logo shadow remains, even if Clear Logo is deactivated. This shadow which extends in the middle of the image is particularly annoying for fast forwards, when looking for a scene which takes place at night for example.

Expected Behavior

However, I think that the best solution would be to distinguish different parameters for fast forward (with left/right click) from the total display (with OK click), so as to minimize the OSD when moving forward, and be not obstruct the image. While information such as the movie title (and the shadow behind it) should be displayed when pressing OK to navigate the OSD.

Steps To Reproduce

...

Screenshots and Additional Info

No response

Checklist

jurialmunkey commented 4 months ago

This is not a bug. It is intentional. Without dimming the background, the osd controls are practically impossible to view on a bright/busy background or when subtitles are visible.

screenshot00565

screenshot00568

Bindou01 commented 4 months ago

This is not a bug. It is intentional. Without dimming the background, the osd controls are practically impossible to view on a bright/busy background or when subtitles are visible.

Of course, shade is essential. What I mean is that the shadow also extends to the left center of the image, where the title/Clear Logo is located, even when Clear Logo is turned off. Consequently, this prevents you from seeing the content of the film, which is annoying when fast forwarding when searching for a scene, especially when the scene is dark. We have to wait for the OSD to disappear to see better.

And as I said, I find that the presence of the Clear Logo is on the other hand very relevant when you display the complete video OSD, by pressing "OK".

This is why I believe that the solution is to differentiate the parameters between partial video OSD for fast forwarding, and full video OSD for navigation within the video OSD (subtitle, bookmarks, etc.).

jurialmunkey commented 4 months ago

The shadow is needed to extend from top left to bottom right in a curve to ensure that the top left header is also visible.

Bindou01 commented 4 months ago

The shadow is needed to extend from top left to bottom right in a curve to ensure that the top left header is also visible.

Yes I understand. However, with Estuary, we do not find this problem. Probably because Estuary displays the Clear Logo small in the top bar. I understand that you want to keep this style specific to Fuse. Is it not possible to display the Clear Logo in small size when fast forwarding (partial display of the Video OSD with a press on the left or right arrow), and leave it in full screen only in display " complete" of the video OSD (when the OK key is pressed) as currently? Finally suppose you can generate a different shadow based on these two posters...?

The video OSD is, in my opinion, the last point that could still be improved. The rest is really pretty and ergonomic at the same time. Congratulations and thank you for everything.